Job type in character's job field.

[Supamiu]

When calling GET /character/:id, the jobs are represented as as object containing objects, but there's no way (no property) to know if the job is a Disciple of Hand, War or Hand.

It could be implemented as a simple field which exposes an enum of ["DoH", "DoW", "DoL"].

Also, jobs should be an array to be easily parseable.

I didn't find any CONTRIBUTING.md file, so I don't know if you accept Pull requests or not (and where is the API code too)

[vekien]

I'll have a look and see if job type is part of the datfiles, otherwise it might be best for you to create a simple array containing the IDs for each discipline.

If it's in dats then I can add it

What language are you using, an object list should be fine in most (it's intended for web languages like PHP or JavaScript)

[Supamiu]

I'm using typescript (compiled as es5). You can see where I'm doing this by looking at this file: https://github.com/noe-fc/client/blob/login/src/app/sidebar/sidebar.component.ts

Problem with this object approach is that the index itself is useless because we already have the id as a property, if classJobs was an array, I wouldn't have to do something like

 for (const job in p.data.classjobs) {
     if (p.data.classjobs.hasOwnProperty(job)) {
         this.jobs.push(p.data.classjobs[job]);
     }
}

Which uses a check (if the property is in the object, because in in typescript iterates accross all of the properies of the object.

Instead, if it was an array, a simple this.jobs = p.data.classJobs would be enough.

[vekien]

I see. yeh, but it doesn't hinder it like it might in C#, I can't really go adjusting things now as there are a lot of people using the API and I can't break their applications. This is something that will be done as part of V3 API where there are no object lists.

[Supamiu]

That's legit ^^

If you need help on the changes, I'd be happy to help, don't hesitate.