Remove memory sanitizer support and related configurations

Author: Alex-PLACET

.github/workflows/sanitizers.yml

@@ -20,7 +20,6 @@ jobs:
         os: [ubuntu-24.04]
         sys:
         - {compiler: clang, version: '21', name: asan, sanitizer: address}
-        - {compiler: clang, version: '21', name: msan, sanitizer: memory}
         - {compiler: clang, version: '21', name: lsan, sanitizer: leak}
         - {compiler: clang, version: '21', name: ubsan, sanitizer: undefined}
         config:
@@ -77,9 +76,6 @@ jobs:
             export ASAN_OPTIONS=log_path=asan_log_:alloc_dealloc_mismatch=0:halt_on_error=0:handle_abort=0
             export ASAN_SAVE_DUMPS=AsanDump.dmp
             ;;
-          memory)
-            export MSAN_OPTIONS=log_path=msan_log_:halt_on_error=0:suppressions=${GITHUB_WORKSPACE}/test/msan_suppressions.txt
-            ;;
           leak)
             export LSAN_OPTIONS=log_path=lsan_log_:halt_on_error=0
             ;;

include/xtensor/core/xoperation.hpp

@@ -20,19 +20,6 @@
 #include "../core/xstrides.hpp"
 #include "../views/xstrided_view.hpp"
 
-// Suppress MSan false positives triggered by deeply nested
-// std::apply + tuple unpacking in xfunction_stepper::operator*().
-// The arithmetic functors below (plus, multiplies, etc.) are trivial
-// and read values that originate from properly initialized arrays.
-#if defined(__has_feature)
-#if __has_feature(memory_sanitizer)
-#define XT_MSAN_NO_SANITIZE __attribute__((no_sanitize("memory")))
-#endif
-#endif
-#ifndef XT_MSAN_NO_SANITIZE
-#define XT_MSAN_NO_SANITIZE
-#endif
-
 namespace xt
 {
 
@@ -45,7 +32,6 @@ namespace xt
     {                                                  \
         template <class A1>                            \
         constexpr auto operator()(const A1& arg) const \
-            XT_MSAN_NO_SANITIZE                        \
         {                                              \
             return OP arg;                             \
         }                                              \
@@ -83,7 +69,6 @@ namespace xt
     {                                                                  \
         template <class T1, class T2>                                  \
         constexpr auto operator()(T1&& arg1, T2&& arg2) const          \
-            XT_MSAN_NO_SANITIZE                                        \
         {                                                              \
             using xt::detail::operator OP;                             \
             return (std::forward<T1>(arg1) OP std::forward<T2>(arg2)); \
@@ -146,7 +131,6 @@ namespace xt
 
             template <class B, class A1, class A2>
             constexpr auto operator()(const B& cond, const A1& v1, const A2& v2) const noexcept
-                XT_MSAN_NO_SANITIZE
             {
                 return xtl::select(cond, v1, v2);
             }
@@ -226,7 +210,6 @@ namespace xt
 
 #undef UNARY_OPERATOR_FUNCTOR
 #undef BINARY_OPERATOR_FUNCTOR
-#undef XT_MSAN_NO_SANITIZE
 
     /*************
      * operators *

test/CMakeLists.txt

@@ -234,12 +234,6 @@ file(GLOB XTENSOR_PREPROCESS_FILES files/cppy_source/*.cppy)
 # Sanitizer support
 include(${CMAKE_SOURCE_DIR}/cmake/sanitizers.cmake)
 
-if(USE_SANITIZER MATCHES "memory" AND CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  # doctest's String union triggers MSan false positives during
-  # static-init reporter registration. Fixed in main.cpp with
-  # __attribute__((no_sanitize("memory"))) on doctest functions.
-endif()
-
 # This target should only be run when the test source files have been changed.
 add_custom_target(
     preprocess_cppy
@@ -312,21 +306,12 @@ endif()
 target_include_directories(test_xtensor_lib PRIVATE ${XTENSOR_INCLUDE_DIR})
 target_link_libraries(test_xtensor_lib PRIVATE xtensor  doctest::doctest ${CMAKE_THREAD_LIBS_INIT})
 
-set(XTENSOR_TEST_ENV)
-if(USE_SANITIZER MATCHES "memory")
-  set(XTENSOR_MSAN_SUPPRESSIONS_FILE "${CMAKE_CURRENT_SOURCE_DIR}/msan_suppressions.txt")
-  set(XTENSOR_TEST_ENV "MSAN_OPTIONS=halt_on_error=0:suppressions=${XTENSOR_MSAN_SUPPRESSIONS_FILE}")
-endif()
-
 add_custom_target(
   xtest
-  COMMAND ${CMAKE_COMMAND} -E env ${XTENSOR_TEST_ENV} $<TARGET_FILE:test_xtensor_lib>
+  COMMAND $<TARGET_FILE:test_xtensor_lib>
   DEPENDS test_xtensor_lib
 )
 add_test(NAME xtest COMMAND test_xtensor_lib)
-if(XTENSOR_TEST_ENV)
-  set_tests_properties(xtest PROPERTIES ENVIRONMENT "${XTENSOR_TEST_ENV}")
-endif()
 
 # Some files will be compiled twice, however compiling common files in a static
 # library and linking test_xtensor_lib with it removes half of the tests at

test/doctest_wrapper.hpp

@@ -2,4 +2,4 @@
 #if defined(XTENSOR_DISABLE_EXCEPTIONS)
 #define DOCTEST_CONFIG_NO_EXCEPTIONS_BUT_WITH_ALL_ASSERTS
 #endif
-#include "doctest_wrapper.hpp"
+#include "doctest/doctest.h"

test/main.cpp

@@ -7,7 +7,7 @@
 
 #include "xtensor/core/xtensor_config.hpp"
 
-#include "doctest_wrapper.hpp"
+#include "doctest/doctest.h"
 #include "test_utils.hpp"
 
 #if defined(XTENSOR_DISABLE_EXCEPTIONS)