review fix

Author: Frotty

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstio/languageserver/WurstBuildConfig.java

@@ -136,9 +136,8 @@ public boolean shouldCopyRunMapToWarcraftMapDir(Optional<GameVersion> detectedVe
     }
 
     public boolean shouldUseInstallDirForMaps(Optional<GameVersion> detectedVersion) {
-        return detectedVersion
-            .map(version -> version.compareTo(new GameVersion("1.27.9")) <= 0)
-            .orElse(wc3PatchOrReforged() == Wc3Patch.PRE_129);
+        return detectedVersion.orElseGet(this::fallbackGameVersion)
+            .compareTo(new GameVersion("1.27.9")) <= 0;
     }
 
     private static String stripComment(String line) {

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/WurstBuildConfigTests.java

@@ -35,6 +35,22 @@ public void readsScriptModeAndPatchFromWurstBuild() throws Exception {
         assertEquals(config.fallbackGameVersion(), new GameVersion("1.28"));
         assertTrue(config.shouldUseClassicWindowArg(Optional.empty()));
         assertFalse(config.shouldUseReforgedLaunchArgs(Optional.empty()));
+        assertFalse(config.shouldUseInstallDirForMaps(Optional.empty()));
+    }
+
+    @Test
+    public void installDirMapPathIsOnlyForDetected127OrLower() throws Exception {
+        Path project = Files.createTempDirectory("wurst-build-config-map-path");
+        Files.writeString(project.resolve("wurst.build"), """
+            projectName: Test
+            wc3Patch: pre1.29
+            """);
+
+        WurstBuildConfig config = WurstBuildConfig.fromWorkspaceRoot(WFile.create(project.toFile()));
+
+        assertTrue(config.shouldUseInstallDirForMaps(Optional.of(new GameVersion("1.27"))));
+        assertFalse(config.shouldUseInstallDirForMaps(Optional.of(new GameVersion("1.28"))));
+        assertFalse(config.shouldUseInstallDirForMaps(Optional.empty()));
     }
 
     @Test