fix RHS

Author: Frotty

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/intermediatelang/optimizer/DispatchCheckDeduplicator.java

@@ -95,6 +95,9 @@ private boolean invalidatesGuard(ImStmt s, GuardPattern guard) {
         if (s instanceof ImSet) {
             ImSet set = (ImSet) s;
             ImLExpr left = set.getLeft();
+            if (mayWriteTypeIdFromElement(set.getRight(), guard.failedCond.typeIdVar)) {
+                return true;
+            }
             if (left instanceof ImVarAccess) {
                 ImVar v = ((ImVarAccess) left).getVar();
                 return v == guard.failedCond.receiverVar || v == guard.failedCond.typeIdVar;
@@ -127,6 +130,21 @@ private boolean invalidatesGuard(ImStmt s, GuardPattern guard) {
         return false;
     }
 
+    private boolean mayWriteTypeIdFromElement(Element elem, ImVar typeIdVar) {
+        if (elem == null) {
+            return false;
+        }
+        if (sideEffectAnalyzer.directlySetVariables(elem).contains(typeIdVar)) {
+            return true;
+        }
+        for (ImFunction called : sideEffectAnalyzer.calledFunctions(elem)) {
+            if (mayWriteTypeId(called, typeIdVar)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     private boolean mayWriteTypeId(ImFunction f, ImVar typeIdVar) {
         if (f == null) {
             return true;

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/ClassesTests.java

@@ -136,6 +136,40 @@ public void repeatedCallsOnSameReceiverAreNotDispatchCachedYet() throws IOExcept
             "Expected inlopt output to contain a single dispatch guard, found " + inlOptGuardCount);
     }
 
+    @Test
+    public void dispatchGuardNotDedupedAcrossRhsSideEffects() throws IOException {
+        testAssertOkLines(false,
+            "package test",
+            "    native testSuccess()",
+            "    class A",
+            "        function bar() returns int",
+            "            return 1",
+            "",
+            "    function mutatingRhs(A a) returns int",
+            "        destroy a",
+            "        return 0",
+            "",
+            "    function useA(A a) returns int",
+            "        int r = 0",
+            "        r += a.bar()",
+            "        r = mutatingRhs(a)",
+            "        r += a.bar()",
+            "        return r",
+            "",
+            "    init",
+            "        let a = new A",
+            "        useA(a)",
+            "        testSuccess()",
+            "endpackage"
+        );
+
+        File inlOptOut = new File(TEST_OUTPUT_PATH + "ClassesTests_dispatchGuardNotDedupedAcrossRhsSideEffects_inlopt.j");
+        String inlOpt = Files.readString(inlOptOut.toPath(), StandardCharsets.UTF_8);
+        int inlOptGuardCount = countOccurrences(inlOpt, "if A_typeId[a] == 0 then");
+        assertTrue(inlOptGuardCount >= 2,
+            "Expected inlopt output to keep separate guards across mutating RHS call, found " + inlOptGuardCount);
+    }
+
     private static int countOccurrences(String text, String needle) {
         int c = 0;
         int i = 0;