review fixes

Author: Frotty

AGENTS.md

@@ -244,7 +244,50 @@ This pipeline handles:
 
 ---
 
-## 8. Backend Parity and Lua Guardrails
+## 8. Shared Project Config, Patch Targets, and Run Behavior
+
+Recent Grill/compiler integration work moved `wurst.build` parsing rules into a tiny shared dependency. Keep compiler behavior aligned with that shared model.
+
+### Shared project config dependency
+
+* `de.peeeq.wurstscript/build.gradle` depends on `com.github.wurstscript:wurst-project-config`.
+* `de.peeeq.wurstio.languageserver.WurstBuildConfig` is a compiler adapter around the shared model, not a second config DAO.
+* Do not duplicate YAML parsing rules, patch aliases, or script-mode behavior in compiler-only code unless it is truly compiler-specific.
+* Preserve exact `wc3Patch` names for cache invalidation and diagnostics. Broad patch kind is useful for behavior choices, but not enough for hashes.
+
+### Patch target rules
+
+* Use the shared `Wc3PatchTarget` parser for `wc3Patch`.
+* Patch family boundaries:
+  * below `1.29` => pre-1.29 behavior
+  * `1.29` through `1.31` => classic
+  * `1.32+`, `1.36`, `2.0`, and `Reforged-*` => Reforged
+* Friendly names and jass-history dump names should resolve through shared config. Do not add one-off aliases in compiler code.
+* If jass-history has a broken folder name, fix `wurstscript/jass-history` instead of compensating here.
+
+### Build vs run
+
+* Build/typecheck should prefer pinned `wc3Patch` from `wurst.build` and should not parse the installed Warcraft executable just to decide target patch data.
+* Config injection should use the pinned project patch when available, not the locally installed game patch.
+* User-facing executable version parsing failures must stay short. Do not print PE parser stack traces unless explicit debug logging is requested.
+* Run/launch is different from build: the selected Warcraft executable controls launch arguments and map placement.
+* When project patch family and selected client family differ, warn and allow the user to choose a different Warcraft III folder.
+* If launch folder selection changes the client, all launch decisions must use that selected `W3InstallationData`, not stale request-level `w3data`.
+* Legacy clients that need install-dir map placement must copy to the selected launch install's `Maps/Test` folder.
+
+### Focused tests
+
+For config and run-pipeline changes, prefer these focused checks before broader test runs:
+
+```
+./gradlew test --tests tests.wurstscript.tests.WurstBuildConfigTests
+./gradlew test --tests tests.wurstscript.tests.MapRequestPatchTargetTests
+./gradlew make_for_userdir
+```
+
+---
+
+## 9. Backend Parity and Lua Guardrails
 
 Recent fixes established additional rules for backend work. Follow these for all future changes:
 
@@ -288,7 +331,7 @@ Recent fixes established additional rules for backend work. Follow these for all
 
 ---
 
-## 9. Virtual Slot Binding and Determinism (New Generics + Lua)
+## 10. Virtual Slot Binding and Determinism (New Generics + Lua)
 
 Recent regressions showed that virtual-slot binding can silently degrade to base/no-op implementations in generated Lua while still compiling. Follow these rules for all related changes:
 

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstio/languageserver/requests/RunMap.java

@@ -145,7 +145,7 @@ private void startGame(WurstGui gui, CompilationResult result) throws Exception
         }
         Optional<GameVersion> detectedGameVersion = launchData.getWc3PatchVersion();
         if (buildConfig.shouldCopyRunMapToWarcraftMapDir(detectedGameVersion)) {
-            mapCopy = copyToWarcraftMapDir(cachedMapFile.get());
+            mapCopy = copyToWarcraftMapDir(cachedMapFile.get(), launchData);
         }
 
 
@@ -353,7 +353,7 @@ private String getWorkspaceAbsolute() {
      * <p>
      * This directory depends on warcraft version and whether we are on windows or wine is used.
      */
-    private File copyToWarcraftMapDir(File testMap) throws IOException {
+    private File copyToWarcraftMapDir(File testMap, W3InstallationData launchData) throws IOException {
         String testMapName = "WurstTestMap.w3x";
         for (String arg : compileArgs) {
             if (arg.startsWith("-runmapTarget")) {
@@ -371,7 +371,7 @@ private File copyToWarcraftMapDir(File testMap) throws IOException {
         }
 
         File myDocumentsFolder = FileSystemView.getFileSystemView().getDefaultDirectory();
-        Optional<String> documentPath = findMapDocumentPath(testMapName, myDocumentsFolder);
+        Optional<String> documentPath = findMapDocumentPath(testMapName, myDocumentsFolder, launchData);
 
         // copy the map to the appropriate directory
         Optional<File> testFolder = documentPath.map(path -> new File(path, "Maps" + File.separator + "Test"));
@@ -404,7 +404,7 @@ private File copyToWarcraftMapDir(File testMap) throws IOException {
         return null;
     }
 
-    private Optional<String> findMapDocumentPath(String testMapName, File myDocumentsFolder) {
+    private Optional<String> findMapDocumentPath(String testMapName, File myDocumentsFolder, W3InstallationData launchData) {
         Optional<String> documentPath = Optional.of(
             langServer.getConfigProvider().getMapDocumentPath().orElseGet(
                 () -> myDocumentsFolder.getAbsolutePath() + File.separator + "Warcraft III"));
@@ -425,13 +425,13 @@ private Optional<String> findMapDocumentPath(String testMapName, File myDocument
             }
         }
 
-        if (buildConfig.shouldUseInstallDirForMaps(w3data.getWc3PatchVersion())) {
+        if (buildConfig.shouldUseInstallDirForMaps(launchData.getWc3PatchVersion())) {
             // 1.27 and lower compat
             WLogger.info("Version 1.27 or lower detected, changing file location");
-            documentPath = wc3Path;
+            documentPath = mapInstallDirectoryForLegacyLaunch(launchData, wc3Path);
         } else {
             // For 1.28+ the wc3/maps/test folder must not contain a map of the same name
-            Optional<File> oldFile = wc3Path.map(
+            Optional<File> oldFile = installRootForLaunchData(launchData).map(File::getAbsolutePath).or(() -> wc3Path).map(
                 w3p -> new File(w3p, "Maps" + File.separator + "Test" + File.separator + testMapName));
             if (oldFile.isPresent() && oldFile.get().exists()) {
                 if (!oldFile.get().delete()) {
@@ -441,4 +441,32 @@ private Optional<String> findMapDocumentPath(String testMapName, File myDocument
         }
         return documentPath;
     }
+
+    private static Optional<String> mapInstallDirectoryForLegacyLaunch(W3InstallationData launchData, Optional<String> fallbackWc3Path) {
+        Optional<File> launchRoot = installRootForLaunchData(launchData);
+        if (launchRoot.isPresent()) {
+            return launchRoot.map(File::getAbsolutePath);
+        }
+        return fallbackWc3Path;
+    }
+
+    private static Optional<File> installRootForLaunchData(W3InstallationData launchData) {
+        return launchData.getGameExe().map(RunMap::installRootForExecutable);
+    }
+
+    private static File installRootForExecutable(File executable) {
+        File parent = executable.getAbsoluteFile().getParentFile();
+        if (parent == null) {
+            return executable.getAbsoluteFile();
+        }
+        if (parent.getName().equalsIgnoreCase("x86") || parent.getName().equalsIgnoreCase("x86_64")) {
+            File maybeRetail = parent.getParentFile();
+            if (maybeRetail != null && (maybeRetail.getName().equalsIgnoreCase("_retail_") || maybeRetail.getName().equalsIgnoreCase("_ptr_"))) {
+                File installRoot = maybeRetail.getParentFile();
+                return installRoot != null ? installRoot : maybeRetail;
+            }
+            return maybeRetail != null ? maybeRetail : parent;
+        }
+        return parent;
+    }
 }

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/MapRequestPatchTargetTests.java

@@ -86,6 +86,29 @@ public void runMapInfersClassicClientFromWar3ExecutablePath() throws Exception {
         assertEquals(request.detectedVersion().orElseThrow(), new GameVersion("1.28"));
     }
 
+    @Test
+    public void legacyRunMapPlacementUsesSelectedLaunchInstall() throws Exception {
+        Path selectedInstall = Files.createTempDirectory("warcraft-selected-legacy");
+        Path exe = Files.writeString(selectedInstall.resolve("war3.exe"), "not a PE file");
+        Path staleFallback = Files.createTempDirectory("warcraft-stale-fallback");
+        W3InstallationData launchData = new W3InstallationData(
+            Optional.of(exe.toFile()),
+            Optional.of(new GameVersion("1.27"))
+        );
+
+        Method placementRoot = RunMap.class.getDeclaredMethod(
+            "mapInstallDirectoryForLegacyLaunch",
+            W3InstallationData.class,
+            Optional.class
+        );
+        placementRoot.setAccessible(true);
+
+        @SuppressWarnings("unchecked")
+        Optional<String> result = (Optional<String>) placementRoot.invoke(null, launchData, Optional.of(staleFallback.toString()));
+
+        assertEquals(result.orElseThrow(), selectedInstall.toFile().getAbsolutePath());
+    }
+
     @Test
     public void configuredVersionSurvivesManualPathLoad() throws Exception {
         W3InstallationData data = new W3InstallationData(Optional.empty(), Optional.of(new GameVersion("2.0")));