some optimizations

Author: Frotty

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/translation/imtranslation/EliminateClasses.java

@@ -628,9 +628,25 @@ private void replaceMethodCall(ImMethodCall mc) {
         ImExprs arguments = JassIm.ImExprs(receiver);
         arguments.addAll(mc.getArguments().removeAll());
 
-        ImFunction dispatch = dispatchFuncs.get(mc.getMethod());
+        ImMethod method = mc.getMethod();
+        // Fast path: with unchecked dispatch, a monomorphic method call can be lowered
+        // directly to its implementation function.
+        if (!checkedDispatch
+            && !method.getIsAbstract()
+            && method.getSubMethods().isEmpty()) {
+            mc.replaceBy(JassIm.ImFunctionCall(
+                mc.getTrace(),
+                method.getImplementation(),
+                JassIm.ImTypeArguments(),
+                arguments,
+                false,
+                CallType.NORMAL));
+            return;
+        }
+
+        ImFunction dispatch = dispatchFuncs.get(method);
         if (dispatch == null) {
-            throw new CompileError(mc.attrTrace().attrSource(), "Could not find dispatch for " + mc.getMethod().getName());
+            throw new CompileError(mc.attrTrace().attrSource(), "Could not find dispatch for " + method.getName());
         }
         mc.replaceBy(JassIm.ImFunctionCall(mc.getTrace(), dispatch, JassIm.ImTypeArguments(), arguments, false, CallType.NORMAL));
 

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/translation/imtranslation/EliminateGenerics.java

@@ -955,6 +955,8 @@ private boolean isGlobalInitStmt(ImSet s, ImVar v) {
     }
 
     private void collectGenericUsages(Element element) {
+        // Cache expensive recursive submethod checks within this traversal.
+        Map<ImMethod, Boolean> hasGenericSubmethodCache = new IdentityHashMap<>();
         element.accept(new Element.DefaultVisitor() {
             @Override
             public void visit(ImFunctionCall f) {
@@ -969,10 +971,19 @@ public void visit(ImMethodCall mc) {
                 super.visit(mc);
                 ImMethod method = mc.getMethod();
                 boolean hasTypeArgs = !mc.getTypeArguments().isEmpty();
-                // Interface/base dispatch methods can be non-generic but still require specialization
-                // when they dispatch to generic implementors.
-                boolean needsDispatchSpecialization =
-                    methodImplementationIsGeneric(method) || hasGenericSubmethodImplementation(method);
+                boolean needsDispatchSpecialization = false;
+                // If type args are present, specialization is unconditional, so avoid extra checks.
+                if (!hasTypeArgs) {
+                    // Interface/base dispatch methods can be non-generic but still require specialization
+                    // when they dispatch to generic implementors.
+                    needsDispatchSpecialization = methodImplementationIsGeneric(method);
+                    if (!needsDispatchSpecialization) {
+                        needsDispatchSpecialization = hasGenericSubmethodCache.computeIfAbsent(
+                            method,
+                            EliminateGenerics.this::hasGenericSubmethodImplementation
+                        );
+                    }
+                }
                 if (hasTypeArgs || needsDispatchSpecialization) {
                     dbg("COLLECT GenericMethodCall: method=" + mc.getMethod().getName() + " " + id(mc.getMethod())
                         + " impl=" + (mc.getMethod().getImplementation() == null ? "null" : (mc.getMethod().getImplementation().getName() + " " + id(mc.getMethod().getImplementation())))