Fix jass string null translation (#1110)

Author: Frotty

.github/workflows/build.yml

@@ -126,6 +126,7 @@ jobs:
             echo "ERROR: expected at least Win + Linux zips."
             exit 1
           fi
+
       - name: Normalize nightly filenames
         shell: bash
         run: |
@@ -139,52 +140,14 @@ jobs:
           done
           echo "Renamed to:"; ls -alh upload
 
-      # Delete old release + tag, then create a fresh one at HEAD
-      - name: Recreate nightly release and tag at HEAD
-        uses: actions/github-script@v7
-        with:
-          script: |
-            const { owner, repo } = context.repo;
-            const tag = 'nightly';
-
-            // Delete existing release (if any)
-            try {
-              const rel = await github.rest.repos.getReleaseByTag({ owner, repo, tag });
-              await github.rest.repos.deleteRelease({ owner, repo, release_id: rel.data.id });
-              core.info(`Deleted release id=${rel.data.id}`);
-            } catch (e) {
-              core.info(`No previous release to delete: ${e.message}`);
-            }
-
-            // Delete tag (if any)
-            try {
-              await github.rest.git.deleteRef({ owner, repo, ref: `tags/${tag}` });
-              core.info('Deleted ref tags/nightly');
-            } catch (e) {
-              core.info(`No existing tag to delete: ${e.message}`);
-            }
-
-            // Create fresh prerelease at the current commit
-            const { data: rel2 } = await github.rest.repos.createRelease({
-              owner, repo,
-              tag_name: tag,
-              target_commitish: context.sha,
-              name: 'Nightly Build (master)',
-              body: 'Nightly build for the latest commit on `master`.\nThis release is automatically updated on each push.',
-              draft: false,
-              prerelease: true,
-              make_latest: 'false'  // MUST be a string
-            });
-            core.setOutput('upload_url', rel2.upload_url);
-
       - name: Publish Nightly Release (upload assets)
         uses: softprops/action-gh-release@v2
         with:
           tag_name: nightly
           target_commitish: ${{ github.sha }}
           prerelease: true
           draft: false
-          make_latest: "false"  # keep as string here too
+          make_latest: "false"
           name: Nightly Build (master)
           body: |
             Nightly build for the latest commit on `master`.
@@ -194,4 +157,3 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/translation/imtojass/ExprTranslation.java

@@ -60,7 +60,7 @@ public static JassExpr translate(ImNull e, ImToJassTranslator translator) {
             } else if (typename.equals("boolean") || typename.equals("bool")) {
                 return JassExprBoolVal(false);
             } else if (typename.equals("string")) {
-                return JassExprStringVal("");
+                return JassExprNull();
             }
         }
 

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/JurstTests.java

@@ -12,6 +12,7 @@
 import java.util.Collections;
 import java.util.Map;
 
+import static org.testng.AssertJUnit.assertFalse;
 import static org.testng.AssertJUnit.assertTrue;
 
 public class JurstTests extends WurstScriptTest {
@@ -340,6 +341,45 @@ public void testKeepTRVEHooked() throws IOException {
         assertTrue(output.contains("real myVar"));
     }
 
+    @Test
+    public void testStringNullCheckStaysNull() throws IOException {
+        String jassCode = Utils.string(
+            "globals",
+            "    string array s__SaveCodes",
+            "    integer PID",
+            "    integer unitSaveID",
+            "endglobals",
+            "",
+            "function main takes nothing returns nothing",
+            "    if s__SaveCodes[PID * 19 + unitSaveID] != null then",
+            "        call BJDebugMsg(\"\")", // could be anything
+            "    endif",
+            "endfunction"
+        );
+
+        String jurstCode = Utils.string(
+            "package test",
+            "endpackage"
+        );
+
+        testJurstWithJass(false, true, jassCode, jurstCode);
+
+        File out = new File("./test-output/JurstJassTest_inlopt.j");
+        String output = com.google.common.io.Files.toString(out, Charsets.UTF_8);
+
+        // Ensure the null check survives as a null check
+        assertTrue(
+            "Expected string null check to stay != null",
+            output.contains("s__SaveCodes[PID * 19 + unitSaveID] != null")
+        );
+
+        // And make sure we did NOT silently change it to empty string
+        assertFalse(
+            "String null check must not become != \"\"",
+            output.contains("s__SaveCodes[PID * 19 + unitSaveID] != \"\"")
+        );
+    }
+
     private void testJurstWithJass(boolean executeProg, boolean withStdLib, String jass, String jurst) {
         Map<String, String> inputs = ImmutableMap.of(
                 "example.j", jass,