restore determinism, fix tests

Author: Frotty

de.peeeq.wurstscript/src/main/java/de/peeeq/datastructures/GraphInterpreter.java

@@ -4,6 +4,7 @@
 import com.google.common.collect.Lists;
 import com.google.common.collect.Sets;
 import de.peeeq.wurstscript.utils.Utils;
+import it.unimi.dsi.fastutil.objects.Object2IntLinkedOpenHashMap;
 import org.eclipse.jdt.annotation.Nullable;
 
 import java.util.*;
@@ -81,8 +82,8 @@ public Set<Set<T>> findStronglyConnectedComponents(List<T> nodes) {
         Deque<T> p = new ArrayDeque<>();
         AtomicInteger c = new AtomicInteger();
         AtomicInteger componentCount = new AtomicInteger();
-        Map<T, Integer> preorderNumber = new HashMap<>();
-        Map<T, Integer> component = new HashMap<>();
+        Object2IntLinkedOpenHashMap<T> preorderNumber = new Object2IntLinkedOpenHashMap<>();
+        Object2IntLinkedOpenHashMap<T> component      = new Object2IntLinkedOpenHashMap<>();
 
         // This stack simulates the recursive calls
         Deque<T> traversalStack = new ArrayDeque<>();

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/BugTests.java

@@ -991,6 +991,23 @@ public void extensionMethodStatic() { // See #614
 
     }
 
+    @Test
+    public void testNameShadowError() {
+        testAssertErrorsLines(true, "Variable x hides an other local variable with the same name",
+            "package Test",
+            "native testSuccess()",
+            "function foo() returns bool",
+            "    var x = 0",
+            "    var sum = 0",
+            "    for x in x",
+            "        sum += x",
+            "    return true",
+            "init",
+            "    if foo()",
+            "        testSuccess()"
+        );
+    }
+
     @Test
     public void testCyclicDependencyError() {
         testAssertErrorsLines(true, "For loop target int doesn't provide a iterator() function",
@@ -999,8 +1016,8 @@ public void testCyclicDependencyError() {
                 "function foo() returns bool",
                 "    var x = 0",
                 "    var sum = 0",
-                "    for x in x",
-                "        sum += x",
+                "    for i in x",
+                "        sum += i",
                 "    return true",
                 "init",
                 "    if foo()",