Fix progress bar wrapping to new line on Windows

[Copilot]

On Windows, the progress bar printed a new line on each update instead of overwriting in place. Windows wraps the cursor when output fills the terminal's full width, leaving no room for the carriage return to stay on the same line.

Changes

• Shell::is_windows() — promoted from private to public; wired up the pre-existing (but unused) WP_CLI_TEST_IS_WINDOWS env var to make Windows detection testable
• Bar::display() — subtract 1 from Shell::columns() on Windows only, ensuring the bar never fills the terminal edge and triggers cursor wrap

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Progress bar goes to new line under windows</issue_title>
<issue_description>The progressbar instead of updating the current row print a new row with the updated values.

To fix this I've found that can be esily fixed by changing into Bar.php line 58 from

$size = Shell::columns();

to

$size = Shell::columns() - 1;

If it was ok as I fix I can also make a pull request for it.

Currently I've not tested it under others OS.</issue_description>

Comments on the Issue (you are @copilot in this section)

@schlessera @marcovalloni That will probably break all other systems, though. You'd need to add this change conditionally for Windows only. @schlessera @marcovalloni Did https://github.com//pull/131 actually fix this issue? Or is this still happening on Windows?

• Fixes Progress bar goes to new line under windows #132

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[codecov]

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
lib/cli/progress/Bar.php	0.00%	2 Missing ⚠️
lib/cli/Shell.php	80.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

Fixes Windows terminal cursor-wrap behavior so the progress bar overwrites the same line instead of printing a new line on each update.

Changes:

• Adjust cli\progress\Bar::display() to keep output under terminal width on Windows by subtracting 1 column.
• Promote cli\Shell::is_windows() to public and make Windows detection controllable via WP_CLI_TEST_IS_WINDOWS for testing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
lib/cli/progress/Bar.php	Avoids filling the full terminal width on Windows to prevent cursor wrap/newline.
lib/cli/Shell.php	Exposes Windows detection publicly and adds an env-var override for tests.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

WP_CLI_TEST_IS_WINDOWS is cast to boolean with (bool) $test_is_windows, which can misinterpret common string values (e.g. 'false' becomes true in PHP). Consider parsing it with filter_var(..., FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE) (and falling back to PHP_OS when parsing returns null) to avoid incorrect Windows detection when the env var is set.

Suggested change

	return (bool) $test_is_windows;
	}
	$parsed_test_is_windows = filter_var(
	$test_is_windows,
	FILTER_VALIDATE_BOOLEAN,
	FILTER_NULL_ON_FAILURE
	);
	if ( null !== $parsed_test_is_windows ) {
	return $parsed_test_is_windows;
	}
	}

[Copilot]

Making is_windows() public introduces a new public API method that uses snake_case while the other public methods on Shell (e.g. columns(), isPiped()) are camelCase. To keep the public API consistent, consider adding a isWindows() alias (and potentially deprecating is_windows() over time), while retaining the existing method for internal/backwards compatibility.

Suggested change

	/**
	* CamelCase alias for {@see Shell::is_windows()} to keep the public API consistent.
	*
	* @return bool
	*/
	static public function isWindows() {
	return self::is_windows();
	}

[Copilot]

Bar::display() now calls Shell::is_windows() on every render, which (with the new implementation) does a getenv() each time. Since progress bars can update very frequently, consider caching the Windows detection result inside Shell::is_windows() (while still allowing the test override env var to take effect) to avoid unnecessary per-tick overhead.