Skip to content

Couple of suggested changes #7

@uxder

Description

@uxder

Here are some quick thoughts.

  • I feel that functions.php should merely be a central location to include sub-files and "function" or "classes" should always live outside this. So presently, we have things like the setup method, widget initialization etc. Perhaps we should move this out to separate files in lib.
  • In functions, wp_enqueue_scripts, we disable jquery if it's not the admin. Although I'm not a fan of jquery but....many plugins rely on it (IE: woocommerce). It took me a while to figure out why my woocommerce plugin wasn't loading JS files because it was disabled. I think we should keep jquery enabled by default.
  • Not too familiar with Jetpack but I feel that the generator should keep minimize assumptions.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions