Propcores propCanCreate() and sentCanCreate() doesn't actually check if it can create said entities

[unknao]

Both of these functions only look to see if the prop burst limit is met or not, they don't take into account the player being blocked from spawning props by any other means, including the prop/sent limit.

Example code:

@strict

propSpawnUndo(0)
event tick() {
    if(!propCanCreate()){ exit() }
    
    let E = propSpawn("models/props_junk/CinderBlock01a.mdl", entity():pos(), ang(), 1)
    if(!E:isValid()){
        print("This should never run!")
    }
}

It will print "This should never run!" after the player prop limit has been reached.

[Astralcircle]

Will require calling PlayerSpawn* twice, some addons may use this for logging, but i think adding it to canSpawn checks is worth it

function PropCore.ValidSpawn(ply, model, vehicleType)
	local ret -- DO NOT RETURN MID-FUNCTION OR 'LimitHit' WILL BREAK
	local limithit = playerMeta.LimitHit
	playerMeta.LimitHit = function() end

	if not (util.IsValidProp( model ) and WireLib.CanModel(ply, model)) then
		ret = false
	elseif vehicleType then
		ret = gamemode.Call( "PlayerSpawnVehicle", ply, model, vehicleType, list.Get( "Vehicles" )[vehicleType] ) ~= false
	else
		ret = gamemode.Call( "PlayerSpawnProp", ply, model ) ~= false
	end

	playerMeta.LimitHit = limithit
	return ret
end
local ValidSpawn = PropCore.ValidSpawn