Skip to content

Correct link to "solution" #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
afs wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Correct link to "solution" #694

afs wants to merge 1 commit into from
+2 −9

Conversation

@afs
Copy link
Contributor

@afs afs commented Dec 8, 2025 •
edited
Loading

Correct link to "solution", remove "binding".

(SHACL Core uses "binding" for prefixes)

@afs afs force-pushed the dfn-links branch 2 times, most recently from a920a1a to e0af305 Compare December 8, 2025 13:11
@afs afs changed the title <dfn> as singluar, align future external <dfn> <dfn> as singluar Dec 8, 2025
@afs afs changed the title <dfn> as singluar <dfn> as singular Dec 8, 2025
robert-david
robert-david approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@robert-david robert-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if i understood this correctly, but the anchors
https://www.w3.org/TR/shacl12-core/#dfn-binding
https://www.w3.org/TR/shacl12-core/#dfn-solution
still don't work.

HolgerKnublauch
HolgerKnublauch requested changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@HolgerKnublauch HolgerKnublauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I noticed that #668 is not yet approved and has the same fix but in shacl-sparql. I suggest to approve that branch instead and change the links to shacl12-sparql as my PR deletes them from shacl-core.

@afs
Copy link
Contributor Author

afs commented Dec 9, 2025

Not sure if i understood this correctly, but the anchors https://www.w3.org/TR/shacl12-core/#dfn-binding https://www.w3.org/TR/shacl12-core/#dfn-solution still don't work.

The TR version is the state of the default to branch (gh-pages) and gets updated-by-bot soon after a merge.

@afs afs requested a review from HolgerKnublauch December 9, 2025 09:46
@afs
Copy link
Contributor Author

afs commented Dec 9, 2025

A link for solution now goes to SPARQL Query.

There is nothing gained by involving SHALCL SPARQL.

@afs afs changed the title <dfn> as singular Correct link to "solution" Dec 9, 2025
@afs
Copy link
Contributor Author

afs commented Dec 9, 2025

@HolgerKnublauch - this needs your review - the previous block remains active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert-david robert-david robert-david approved these changes

@HolgerKnublauch HolgerKnublauch Awaiting requested review from HolgerKnublauch

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@afs @HolgerKnublauch @robert-david