I can't build / Build Error

[era760]

I use DeepL because I don’t speak English. Also, please excuse the long message.

Hello. I’m a big fan of Voidstrap. By the way, I was getting a little frustrated that there were no Japanese strings at all. So, I decided to contribute to the Japanese localization. However, I encountered build errors due to a few issues, so I’d like to ask what the correct state should be. You can check the diff in my latest commit on the fix/japanese-translation branch of my fork, which is the version I got to work without build errors. However, since I know almost no C#, I’m working with AI. Therefore, I won’t be submitting this as a PR. I hope you can use this as a reference to rewrite the code.

1. Conflict in MusicPlayerViewModel.cs
   Regarding MusicPlayerViewModel in Bloxstrap/UI/ViewModels/ContextMenu, for some reason, there are versions with and without a space before the file extension. This seems to cause CS0111 errors during the build. I removed the version with the space. However, this led to the following issue:

2. Missing property in AppSettings.cs
   This seems to cause error CS1061. (e.g., “AppSettings does not contain a definition for ‘SwiftTunnelRememberLogin’”)

3. NLua dependency not found
   This is the final issue. Error CS0246: “The type or namespace name ‘NLua’ could not be found.”
   Fix: The .csproj file is missing the PackageReference for NLua. I had to manually run dotnet add package NLua to restore the build environment.

After making these fixes, the project built successfully (it took about 110 seconds on my machine!). It seems to be working fine now. However, this is the only part that’s still bothering me. I’d like to know if my solutions are correct, and if so, I’d appreciate it if you could implement them. Finally, to reiterate what I wrote earlier, you can view the diff in my latest commit on the fix/japanese-translation branch of my fork, which brings the project to a state where no build errors occur. However, since I have very little C# experience, I’m working with an AI. Therefore, I won’t be submitting this as a PR. I hope you can use this as a reference to rewrite the code.

Sorry for the long message.

Translated with DeepL.com (free version)

[era760]

era760@798347e
You can view the changes here

[KloBraticc]

ok thank you