Skip to content

Conversation

@Concurrensee
Copy link
Contributor

This PR fixes AMD Examples Test Group

@Concurrensee Concurrensee force-pushed the fix_amd_examples_test branch from 3784787 to 241d964 Compare December 8, 2025 19:36
@mergify
Copy link

mergify bot commented Dec 8, 2025

Documentation preview: https://vllm--30276.org.readthedocs.build/en/30276/

@mergify mergify bot added documentation Improvements or additions to documentation rocm Related to AMD ROCm labels Dec 8, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a CI issue for AMD examples by setting the attention backend to FLEX_ATTENTION on ROCm platforms. While the use of os.environ is a valid approach, I've suggested a safer and more explicit alternative that modifies the parsed arguments locally. This avoids modifying global state and improves the code's clarity and robustness.

@mergify
Copy link

mergify bot commented Dec 8, 2025

Hi @Concurrensee, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

@Concurrensee Concurrensee force-pushed the fix_amd_examples_test branch 2 times, most recently from abb1d8a to 40790e0 Compare December 8, 2025 20:13
@mergify mergify bot added the ci/build label Dec 8, 2025
Signed-off-by: Yida Wu <yida.wu@amd.com>
open-clip-torch==2.32.0

# Required for Examples test
vllm[audio]==0.11.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe? will it override the vllm version?

I suggest following test.txt by specifying the packages directly, avoid using vllm[audio]==0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants