fix(cli): restore friendly compile errors in direct script runner

Author: GaspardKirira

include/vix/cli/commands/run/RunDetail.hpp

@@ -492,8 +492,8 @@ namespace vix::commands::RunCommand::detail
       const std::string &spinnerLabel,
       bool passthroughRuntime,
       int timeoutSec = 0,
-      bool useSan = false);
-
+      bool useSan = false,
+      bool captureOnly = false);
   /**
    * @brief Run a command and capture its output plus exit code.
    */

src/ErrorHandler.cpp

@@ -206,6 +206,15 @@ namespace vix::cli
     const std::string cleanedLog = ::trim_build_preamble(buildLog);
     auto errors = ClangGccParser::parse(cleanedLog);
 
+    std::cerr << "[DEBUG PARSER] errors.size()=" << errors.size() << "\n";
+    for (const auto &e : errors)
+    {
+      std::cerr << "[DEBUG PARSER] file=" << e.file
+                << " line=" << e.line
+                << " col=" << e.column
+                << " msg=" << e.message << "\n";
+    }
+
     if (errors.empty())
     {
       if (handle_unrecognized_cli_option_as_script_runtime_args(cleanedLog))

src/commands/run/RunProcess.cpp

@@ -95,7 +95,8 @@ namespace vix::commands::RunCommand::detail
       const std::string &spinnerLabel,
       bool passthroughRuntime,
       int timeoutSec,
-      bool useSan)
+      bool useSan,
+      bool captureOnly)
   {
     (void)spinnerLabel;
     (void)passthroughRuntime;
@@ -1092,7 +1093,8 @@ namespace vix::commands::RunCommand::detail
       const std::string &spinnerLabel,
       bool passthroughRuntime,
       int timeoutSec,
-      bool useSan)
+      bool useSan,
+      bool captureOnly)
   {
     SigintGuard sigGuard;
     LiveRunResult result;
@@ -1121,7 +1123,6 @@ namespace vix::commands::RunCommand::detail
     close_safe(pty.slaveFd);
     ::setpgid(pid, pid);
 
-    const bool captureOnly = false;
     const bool forwardStdin =
         passthroughRuntime && (::isatty(STDIN_FILENO) != 0);
 

src/commands/run/RunScript.cpp

@@ -920,14 +920,26 @@ namespace vix::commands::RunCommand::detail
               "Compiling script...",
               false,
               0,
-              o.enableSanitizers || o.enableUbsanOnly);
+              o.enableSanitizers || o.enableUbsanOnly,
+              true);
 
           if (build.exitCode != 0)
           {
-            if (!build.failureHandled)
-              handle_runtime_exit_code(build.exitCode, "compile", false);
+            bool handled = false;
 
-            return build.exitCode == 0 ? 1 : build.exitCode;
+            if (!build.stdoutText.empty() || !build.stderrText.empty())
+            {
+              const std::string compileLog = build.stdoutText + build.stderrText;
+              handled = vix::cli::ErrorHandler::printBuildErrors(
+                  compileLog,
+                  directPlan.scriptPath,
+                  "Script compile failed");
+            }
+
+            if (!handled)
+              error("Script compile failed.");
+
+            return build.exitCode != 0 ? build.exitCode : 1;
           }
 
           // Do not rewrite legacy cache metadata here.

src/commands/run/detail/DirectScriptRunner.cpp

@@ -477,27 +477,40 @@ namespace vix::commands::RunCommand::detail
           "Compiling script...",
           false,
           0,
-          opt.enableSanitizers || opt.enableUbsanOnly);
+          opt.enableSanitizers || opt.enableUbsanOnly,
+          true);
 
       if (build.exitCode != 0)
       {
+        std::cerr << "[DEBUG NEW VIX] direct compile failure path reached\n";
+        std::cerr << "[DEBUG NEW VIX] exitCode=" << build.exitCode << "\n";
+        std::cerr << "[DEBUG NEW VIX] stdout empty=" << std::boolalpha << build.stdoutText.empty() << "\n";
+        std::cerr << "[DEBUG NEW VIX] stderr empty=" << std::boolalpha << build.stderrText.empty() << "\n";
+
+        bool handled = false;
+
         if (!build.stdoutText.empty() || !build.stderrText.empty())
         {
           const std::string compileLog = build.stdoutText + build.stderrText;
-          const bool handled = vix::cli::ErrorHandler::printBuildErrors(
+
+          std::cerr << "[DEBUG NEW VIX] compileLog size=" << compileLog.size() << "\n";
+          std::cerr << "[DEBUG NEW VIX] calling printBuildErrors(...)\n";
+
+          handled = vix::cli::ErrorHandler::printBuildErrors(
               compileLog,
               plan.scriptPath,
               "Script compile failed");
 
-          if (!handled && !build.printed_live)
-            handle_runtime_exit_code(build.exitCode, "compile", false);
+          std::cerr << "[DEBUG NEW VIX] printBuildErrors handled=" << handled << "\n";
         }
-        else if (!build.failureHandled && !build.printed_live)
+
+        if (!handled)
         {
-          handle_runtime_exit_code(build.exitCode, "compile", false);
+          std::cerr << "[DEBUG NEW VIX] fallback: error(\"Script compile failed.\")\n";
+          error("Script compile failed.");
         }
 
-        return -build.exitCode;
+        return build.exitCode != 0 ? build.exitCode : 1;
       }
 
       const std::string meta = make_direct_cache_meta(plan.scriptPath, plan);

src/errors/ClangGccParser.cpp

@@ -25,23 +25,61 @@
 #endif
 
 #include <sstream>
+#include <string>
+#include <algorithm>
+#include <cctype>
 
 namespace vix::cli::errors
 {
+  namespace
+  {
+    std::string trim_copy(std::string s)
+    {
+      while (!s.empty() &&
+             (s.back() == '\n' || s.back() == '\r' || s.back() == ' ' || s.back() == '\t'))
+      {
+        s.pop_back();
+      }
+
+      std::size_t i = 0;
+      while (i < s.size() &&
+             (s[i] == '\n' || s[i] == '\r' || s[i] == ' ' || s[i] == '\t'))
+      {
+        ++i;
+      }
+
+      s.erase(0, i);
+      return s;
+    }
+
+    std::string strip_ansi(std::string s)
+    {
+      static const std::regex ansiRe(R"(\x1B\[[0-9;?]*[ -/]*[@-~])");
+      return std::regex_replace(s, ansiRe, "");
+    }
+  }
+
   std::vector<CompilerError> ClangGccParser::parse(const std::string &buildLog)
   {
     std::vector<CompilerError> out;
 
-    // Example:
+    // GCC / Clang examples:
     // /path/main.cpp:3:5: error: use of undeclared identifier 'std'
     // /path/foo.hpp:1:10: fatal error: 'h.hpp' file not found
-    std::regex re(R"((.+?):(\d+):(\d+):\s*(fatal error|error|warning):\s*(.+))");
+    // /path/main.cpp:2:10: fatal error: huh.hpp: No such file or directory
+    static const std::regex re(
+        R"(^(.+?):([0-9]+):([0-9]+):\s*(fatal error|error|warning):\s*(.+)$)");
 
     std::istringstream iss(buildLog);
     std::string line;
+
     while (std::getline(iss, line))
     {
-      // Ignore make/ninja noise
+      line = strip_ansi(trim_copy(line));
+
+      if (line.empty())
+        continue;
+
       if (line.rfind("gmake", 0) == 0 ||
           line.rfind("make", 0) == 0 ||
           line.rfind("ninja", 0) == 0)
@@ -50,20 +88,21 @@ namespace vix::cli::errors
       }
 
       std::smatch m;
-      if (std::regex_match(line, m, re))
+      if (std::regex_search(line, m, re))
       {
         CompilerError e;
-        e.file = m[1].str();
+        e.file = trim_copy(m[1].str());
         e.line = std::stoi(m[2].str());
         e.column = std::stoi(m[3].str());
-        // m[4] = "fatal error" | "error" | "warning"
-        e.message = m[5].str();
+
+        const std::string severity = m[4].str();
+        const std::string message = trim_copy(m[5].str());
+
+        e.message = severity + ": " + message;
         e.raw = line;
 
-        if (m[4].str() == "error" || m[4].str() == "fatal error")
-        {
+        if (severity == "error" || severity == "fatal error")
           out.push_back(std::move(e));
-        }
       }
     }
 

src/errors/RawLogDetectors.cpp

@@ -399,14 +399,8 @@ namespace vix::cli::errors
         const std::string &runtimeLog,
         const std::filesystem::path &sourceFile)
     {
-      (void)runtimeLog;
-
       std::cerr << RED
-                << "runtime error: program failed at runtime"
-                << RESET << "\n";
-
-      std::cerr << YELLOW
-                << "hint: no specialized runtime rule matched this failure"
+                << "runtime error: unclassified runtime failure"
                 << RESET << "\n";
 
       if (!sourceFile.empty())
@@ -416,6 +410,14 @@ namespace vix::cli::errors
                   << RESET << "\n";
       }
 
+      if (!runtimeLog.empty())
+      {
+        std::cerr << "\n";
+        std::cerr << runtimeLog;
+        if (runtimeLog.back() != '\n')
+          std::cerr << "\n";
+      }
+
       return true;
     }
 
@@ -1297,12 +1299,26 @@ namespace vix::cli::errors
       const std::filesystem::path &sourceFile,
       [[maybe_unused]] const std::string &contextMessage)
   {
-    if (handleRuntimeAnything(buildLog, sourceFile))
-      return true;
-
     if (handleLinkerErrors(buildLog, sourceFile))
       return true;
 
+    const bool looksRuntime =
+        icontains(buildLog, "AddressSanitizer") ||
+        icontains(buildLog, "UndefinedBehaviorSanitizer") ||
+        icontains(buildLog, "LeakSanitizer") ||
+        icontains(buildLog, "ThreadSanitizer") ||
+        icontains(buildLog, "MemorySanitizer") ||
+        icontains(buildLog, "runtime error:") ||
+        icontains(buildLog, "Segmentation fault") ||
+        icontains(buildLog, "SIGSEGV") ||
+        icontains(buildLog, "SIGABRT") ||
+        icontains(buildLog, "Aborted") ||
+        icontains(buildLog, "terminate called after") ||
+        icontains(buildLog, "what():");
+
+    if (looksRuntime)
+      return handleRuntimeAnything(buildLog, sourceFile);
+
     return false;
   }