feat(cli): hide normal log disconnect noise

Author: GaspardKirira

include/vix/cli/commands/logs/LogsAnalyzer.hpp

@@ -83,6 +83,11 @@ namespace vix::commands::logs::analyzer
      * @brief Number of common network disconnect groups detected.
      */
     int networkDisconnectGroups{0};
+
+    /**
+     * @brief Number of normal network noise lines hidden from repeated errors.
+     */
+    int hiddenNormalNoiseLines{0};
   };
 
   /**

src/commands/logs/LogsAnalyzer.cpp

@@ -100,9 +100,13 @@ namespace vix::commands::logs::analyzer
         return "connection reset by peer";
       }
 
-      if (line.find("client closed connection") != std::string::npos ||
+      if (line.find("client disconnected") != std::string::npos ||
+          line.find("client_closed") != std::string::npos ||
+          line.find("client closed connection") != std::string::npos ||
           line.find("client prematurely closed connection") != std::string::npos ||
-          line.find("broken pipe") != std::string::npos)
+          line.find("broken pipe") != std::string::npos ||
+          line.find("detail=eof") != std::string::npos ||
+          line.find(" eof") != std::string::npos)
       {
         return "client disconnected";
       }
@@ -136,6 +140,13 @@ namespace vix::commands::logs::analyzer
 
       return {};
     }
+
+    bool is_normal_network_noise(const std::string &group)
+    {
+      return group == "client disconnected" ||
+             group == "connection reset by peer" ||
+             group == "websocket disconnected";
+    }
   }
 
   RepeatedLogReport analyze_repeated_errors(
@@ -154,13 +165,21 @@ namespace vix::commands::logs::analyzer
       if (normalized.empty())
         continue;
 
-      ++repeatedCounts[normalized];
-
       const std::string networkGroup =
           detect_network_group(normalized);
 
       if (!networkGroup.empty())
+      {
         ++networkCounts[networkGroup];
+
+        if (is_normal_network_noise(networkGroup))
+        {
+          ++report.hiddenNormalNoiseLines;
+          continue;
+        }
+      }
+
+      ++repeatedCounts[normalized];
     }
 
     for (const auto &[message, count] : repeatedCounts)
@@ -253,6 +272,14 @@ namespace vix::commands::logs::analyzer
         "Detected groups",
         std::to_string(report.networkDisconnectGroups));
 
+    if (report.hiddenNormalNoiseLines > 0)
+    {
+      vix::cli::util::kv(
+          out,
+          "Hidden normal noise",
+          std::to_string(report.hiddenNormalNoiseLines) + " lines");
+    }
+
     if (report.networkGroups.empty())
     {
       vix::cli::util::ok_line(

src/commands/logs/LogsRunner.cpp

@@ -56,6 +56,11 @@ namespace vix::commands::logs::runner
       return "grep -Ei 'error|failed|failure|exception|panic|fatal|critical|timeout|refused|denied'";
     }
 
+    std::string grep_analysis_command()
+    {
+      return "grep -Ei 'error|failed|failure|exception|panic|fatal|critical|timeout|refused|denied|disconnect|disconnected|closed|reset by peer|broken pipe|eof'";
+    }
+
     std::string build_journalctl_command(
         const LogsConfig &cfg,
         const LogsOptions &options)
@@ -91,6 +96,30 @@ namespace vix::commands::logs::runner
       return cmd;
     }
 
+    std::string build_journalctl_analysis_command(
+        const LogsConfig &cfg,
+        const LogsOptions &options)
+    {
+      std::string cmd =
+          "journalctl -u " +
+          shell_quote(cfg.serviceName);
+
+      if (!options.since.empty())
+      {
+        cmd += " --since ";
+        cmd += shell_quote(options.since);
+      }
+
+      cmd += " -n ";
+      cmd += std::to_string(cfg.lines);
+      cmd += " --no-pager";
+
+      cmd += " | ";
+      cmd += grep_analysis_command();
+
+      return cmd;
+    }
+
     std::vector<std::string> read_command_lines(
         const std::string &cmd)
     {
@@ -163,7 +192,7 @@ namespace vix::commands::logs::runner
       if (!cfg.serviceName.empty())
       {
         const std::string appCommand =
-            build_journalctl_command(cfg, options);
+            build_journalctl_analysis_command(cfg, options);
 
         output::step(std::cout, "Analyze App Errors");
         output::ok(std::cout, "reading systemd app errors");