fix(cli): integrate db module and clean warnings

Author: GaspardKirira

CMakeLists.txt

@@ -151,7 +151,8 @@ else()
   set(_VIX_P2P_DIR      "${_VIX_MODULES_DIR}/p2p")
   set(_VIX_SYNC_DIR     "${_VIX_MODULES_DIR}/sync")
   set(_VIX_CACHE_DIR    "${_VIX_MODULES_DIR}/cache")
-  set(_VIX_AGENT_DIR    "${_VIX_MODULES_DIR}/agent")
+  set(_VIX_AGENT_DIR     "${_VIX_MODULES_DIR}/agent")
+  set(_VIX_DB_DIR        "${_VIX_MODULES_DIR}/db")
   set(_VIX_WEBSOCKET_DIR "${_VIX_MODULES_DIR}/websocket")
 
   set(_LOCAL_LAYOUT_OK FALSE)
@@ -206,6 +207,12 @@ else()
       add_subdirectory("${_VIX_AGENT_DIR}" "${CMAKE_BINARY_DIR}/_vix_ai_agent")
     endif()
 
+    if (EXISTS "${_VIX_DB_DIR}/CMakeLists.txt" AND NOT TARGET vix::db)
+      set(VIX_DB_BUILD_TESTS OFF CACHE BOOL "" FORCE)
+      set(VIX_DB_BUILD_EXAMPLES OFF CACHE BOOL "" FORCE)
+      add_subdirectory("${_VIX_DB_DIR}" "${CMAKE_BINARY_DIR}/_vix_db")
+    endif()
+
     if (EXISTS "${_VIX_WEBSOCKET_DIR}/CMakeLists.txt" AND NOT TARGET vix::websocket)
       set(VIX_WEBSOCKET_BUILD_EXAMPLES OFF CACHE BOOL "" FORCE)
       add_subdirectory("${_VIX_WEBSOCKET_DIR}" "${CMAKE_BINARY_DIR}/_vix_websocket")
@@ -259,6 +266,10 @@ else()
       list(APPEND _VIX_LOCAL_LINK_TARGETS vix::ai_agent)
     endif()
 
+    if (TARGET vix::db)
+      list(APPEND _VIX_LOCAL_LINK_TARGETS vix::db)
+    endif()
+
     if (TARGET vix::websocket)
       list(APPEND _VIX_LOCAL_LINK_TARGETS vix::websocket)
     endif()
@@ -279,6 +290,7 @@ else()
     vix_append_if_exists(_VIX_LOCAL_INCLUDE_DIRS "${_VIX_SYNC_DIR}/include")
     vix_append_if_exists(_VIX_LOCAL_INCLUDE_DIRS "${_VIX_CACHE_DIR}/include")
     vix_append_if_exists(_VIX_LOCAL_INCLUDE_DIRS "${_VIX_AGENT_DIR}/include")
+    vix_append_if_exists(_VIX_LOCAL_INCLUDE_DIRS "${_VIX_DB_DIR}/include")
     vix_append_if_exists(_VIX_LOCAL_INCLUDE_DIRS "${_VIX_WEBSOCKET_DIR}/include")
     vix_append_if_exists(_VIX_LOCAL_INCLUDE_DIRS "${_VIX_P2P_DIR}/include")
 
@@ -341,6 +353,17 @@ else()
   message(STATUS "[cli] Game command disabled: vix::game target not found")
 endif()
 
+# ----------------------------------------------------
+# Optional db command support
+# ----------------------------------------------------
+if (TARGET vix::db)
+  message(STATUS "[cli] DB command enabled")
+  target_link_libraries(vix_cli PRIVATE vix::db)
+  target_compile_definitions(vix_cli PRIVATE VIX_CLI_HAS_DB=1)
+else()
+  message(STATUS "[cli] DB command disabled: vix::db target not found")
+endif()
+
 # ----------------------------------------------------
 # Optional websocket command support
 # ----------------------------------------------------

src/build/BuildStyle.cpp

@@ -103,18 +103,6 @@ namespace vix::cli::build
           << "\n";
     }
 
-    static void print_optional_line(
-        std::ostream &out,
-        const std::string &label,
-        const std::string &value)
-    {
-      if (value.empty())
-        return;
-
-      print_label(out, label);
-      out << "    " << value << "\n\n";
-    }
-
     static void print_compact_optional_line(
         std::ostream &out,
         const std::string &label,

src/commands/AgentCommand.cpp

@@ -138,20 +138,6 @@ namespace vix::commands::AgentCommand
       return std::to_string(timeout_ms) + "ms";
     }
 
-    [[nodiscard]] std::string format_duration_ms(long long milliseconds)
-    {
-      std::ostringstream oss;
-
-      const double seconds =
-          static_cast<double>(milliseconds) / 1000.0;
-
-      oss.setf(std::ios::fixed);
-      oss.precision(seconds >= 10.0 ? 1 : 2);
-      oss << seconds << "s";
-
-      return oss.str();
-    }
-
     [[nodiscard]] bool parse_options(
         const std::vector<std::string> &args,
         Options &options)

src/commands/BuildCommand.cpp

@@ -2035,25 +2035,6 @@ namespace vix::commands::BuildCommand
       return false;
     }
 
-    static bool node_metadata_changed(
-        const build::BuildNode &current,
-        const build::BuildNode &previous)
-    {
-      if (current.hash != previous.hash)
-        return true;
-
-      if (current.size != previous.size)
-        return true;
-
-      if (current.mtime != previous.mtime)
-        return true;
-
-      if (current.state != previous.state)
-        return true;
-
-      return false;
-    }
-
     static std::string explain_node_change(
         const build::BuildNode &current,
         const build::BuildNode *previous)

src/commands/InstallCommand.cpp

@@ -220,11 +220,6 @@ namespace vix::commands
       return store_git_dir() / sanitize_id_dot(id) / commit;
     }
 
-    static fs::path global_pkg_dir(const std::string &id, const std::string &commit)
-    {
-      return global_pkgs_dir() / sanitize_id_dot(id) / commit;
-    }
-
     static fs::path entry_path(const std::string &ns, const std::string &name)
     {
       return registry_index_dir() / (ns + "." + name + ".json");

src/commands/db/DbMigrator.cpp

@@ -13,8 +13,11 @@
 #include <vix/cli/commands/db/DbMigrator.hpp>
 #include <vix/cli/commands/db/DbOutput.hpp>
 #include <vix/cli/util/Ui.hpp>
+
+#ifdef VIX_CLI_HAS_DB
 #include <vix/db/Database.hpp>
 #include <vix/db/mig/FileMigrationsRunner.hpp>
+#endif
 
 #include <exception>
 #include <filesystem>
@@ -27,23 +30,11 @@ namespace vix::commands::db::migrator
 {
   namespace
   {
-    /**
-     * @brief Check whether the selected database engine is SQLite.
-     *
-     * @param cfg Database configuration.
-     * @return true if SQLite is selected.
-     */
     bool is_sqlite(const DbConfig &cfg)
     {
       return cfg.engine == DbEngine::SQLite;
     }
 
-    /**
-     * @brief Validate filesystem preconditions before running migrations.
-     *
-     * @param cfg Database configuration.
-     * @return true if migration can continue.
-     */
     bool validate_migration_inputs(const DbConfig &cfg)
     {
       if (!is_sqlite(cfg))
@@ -54,7 +45,7 @@ namespace vix::commands::db::migrator
 
         output::fix(
             std::cerr,
-            "set database.engine to sqlite or use the ORM command for other engines");
+            "set database.engine to sqlite");
 
         return false;
       }
@@ -90,11 +81,6 @@ namespace vix::commands::db::migrator
       return true;
     }
 
-    /**
-     * @brief Print the migration summary.
-     *
-     * @param cfg Database configuration.
-     */
     void print_migration_summary(const DbConfig &cfg)
     {
       output::step(std::cout, "Database Migrations");
@@ -111,6 +97,17 @@ namespace vix::commands::db::migrator
   {
     (void)options;
 
+#ifndef VIX_CLI_HAS_DB
+    output::error(
+        std::cerr,
+        "vix db migrate is not available in this build.");
+
+    output::fix(
+        std::cerr,
+        "rebuild the Vix CLI with the db module enabled");
+
+    return 1;
+#else
     if (!validate_migration_inputs(cfg))
       return 1;
 
@@ -143,5 +140,6 @@ namespace vix::commands::db::migrator
 
       return 1;
     }
+#endif
   }
 }