fix(update): preserve manifest metadata when updating deps

Author: GaspardKirira

src/commands/UpdateCommand.cpp

@@ -271,7 +271,13 @@ namespace vix::commands
         {
           UpdateItem item;
           item.id = dep.id;
-          item.rawSpec = make_raw_spec(dep.id, dep.requested);
+
+          // Important:
+          // vix update without an explicit version must resolve the latest
+          // available version from the registry, not reuse the old requested
+          // version from vix.json.
+          item.rawSpec = dep.id;
+
           item.beforeVersion = read_locked_version(lock, dep.id);
           items.push_back(item);
         }
@@ -313,10 +319,11 @@ namespace vix::commands
         }
         else
         {
-          const std::string requested = read_manifest_requested(manifestDeps, id);
-          item.rawSpec = make_raw_spec(id, requested);
+          // Important:
+          // vix update namespace/name must also resolve the latest version.
+          // Do not reuse the old version range from vix.json here.
+          item.rawSpec = id;
         }
-
         items.push_back(item);
       }
 

src/util/Manifest.cpp

@@ -125,6 +125,17 @@ namespace vix::cli::util::manifest
       const Manifest &manifest)
   {
     json root = json::object();
+
+    if (fs::exists(manifestPath))
+    {
+      root = read_json_or_throw(manifestPath);
+
+      if (!root.is_object())
+      {
+        throw std::runtime_error("invalid vix.json: root must be an object");
+      }
+    }
+
     root["deps"] = json::array();
 
     for (const auto &dependency : manifest.dependencies)
@@ -159,25 +170,50 @@ namespace vix::cli::util::manifest
       throw std::runtime_error("manifest dependency requested version cannot be empty");
     }
 
-    Manifest manifest = read_manifest_or_throw(manifestPath);
+    json root = json::object();
+
+    if (fs::exists(manifestPath))
+    {
+      root = read_json_or_throw(manifestPath);
+
+      if (!root.is_object())
+      {
+        throw std::runtime_error("invalid vix.json: root must be an object");
+      }
+    }
+
+    if (!root.contains("deps"))
+    {
+      root["deps"] = json::array();
+    }
+
+    if (!root["deps"].is_array())
+    {
+      throw std::runtime_error("invalid vix.json: deps must be an array");
+    }
 
     bool updated = false;
 
-    for (auto &item : manifest.dependencies)
+    for (auto &item : root["deps"])
     {
-      if (item.id == dependency.id)
+      if (!item.is_object())
       {
-        item.requested = dependency.requested;
+        throw std::runtime_error("invalid vix.json: dependency entry must be an object");
+      }
+
+      if (item.value("id", "") == dependency.id)
+      {
+        item["version"] = dependency.requested;
         updated = true;
         break;
       }
     }
 
     if (!updated)
     {
-      manifest.dependencies.push_back(dependency);
+      root["deps"].push_back(dependency_to_json(dependency));
     }
 
-    write_manifest_or_throw(manifestPath, manifest);
+    write_json_or_throw(manifestPath, root);
   }
 }