Remove unused CLI helpers and fix replay sign conversions

Author: GaspardKirira

src/ErrorHandler.cpp

@@ -20,10 +20,8 @@
 #include <vix/cli/errors/ErrorPipeline.hpp>
 #include <vix/cli/errors/RawLogDetectors.hpp>
 #include <vix/cli/errors/build/BuildErrorDetectors.hpp>
-#include <vix/utils/Env.hpp>
 
 #include <algorithm>
-#include <cstring>
 #include <iostream>
 #include <sstream>
 #include <string>
@@ -54,25 +52,6 @@ namespace
               << "\n";
   }
 
-  vix::cli::build::BuildDiagnostic make_build_diagnostic(
-      const vix::cli::errors::CompilerError &err,
-      const std::string &contextMessage)
-  {
-    vix::cli::build::BuildDiagnostic diagnostic;
-
-    diagnostic.title = contextMessage.empty()
-                           ? "Build failed"
-                           : contextMessage;
-
-    diagnostic.error = err.message;
-
-    diagnostic.location.file = err.file;
-    diagnostic.location.line = static_cast<std::size_t>(err.line);
-    diagnostic.location.column = static_cast<std::size_t>(err.column);
-
-    return diagnostic;
-  }
-
   std::vector<std::string> read_code_frame_lines(
       const fs::path &file,
       std::size_t line,
@@ -223,17 +202,6 @@ namespace
     return true;
   }
 
-  bool hints_verbose_enabled() noexcept
-  {
-    const char *level = vix::utils::vix_getenv("VIX_LOG_LEVEL");
-
-    if (!level || !*level)
-      return false;
-
-    return std::strcmp(level, "debug") == 0 ||
-           std::strcmp(level, "trace") == 0;
-  }
-
   std::size_t line_start(std::string_view text, std::size_t pos)
   {
     if (pos == std::string_view::npos)

src/build/BuildNinja.cpp

@@ -253,17 +253,6 @@ namespace vix::cli::build
       return rule;
     }
 
-    static void append_paths(
-        std::vector<fs::path> &out,
-        const fs::path &base,
-        const std::string &text)
-    {
-      const auto tokens = tokenize_ninja_paths(text);
-      const auto paths = resolve_path_tokens(base, tokens);
-
-      out.insert(out.end(), paths.begin(), paths.end());
-    }
-
     static std::optional<NinjaEdge> parse_build_edge(
         const std::vector<std::string> &lines,
         std::size_t &index,

src/build/BuildStyle.cpp

@@ -18,11 +18,11 @@
 
 #include <cctype>
 #include <iostream>
+#include <optional>
 #include <regex>
 #include <sstream>
 #include <system_error>
 #include <vector>
-#include <optional>
 
 #include <vix/cli/Style.hpp>
 
@@ -39,27 +39,6 @@ namespace vix::cli::build
 
   namespace
   {
-    static std::string trim_copy(const std::string &value)
-    {
-      std::size_t begin = 0;
-
-      while (begin < value.size() &&
-             std::isspace(static_cast<unsigned char>(value[begin])))
-      {
-        ++begin;
-      }
-
-      std::size_t end = value.size();
-
-      while (end > begin &&
-             std::isspace(static_cast<unsigned char>(value[end - 1])))
-      {
-        --end;
-      }
-
-      return value.substr(begin, end - begin);
-    }
-
     static bool is_absolute_or_relative_path_like(const std::string &value)
     {
       if (value.empty())

src/build/ObjectCache.cpp

@@ -316,13 +316,6 @@ namespace vix::cli::build
       return !ec;
     }
 
-    static std::string manifest_path_for_key(
-        const fs::path &root,
-        const std::string &key)
-    {
-      return (root / key / "manifest.json").string();
-    }
-
     static std::uint64_t hash_file_content(const fs::path &path)
     {
       std::ifstream in(path, std::ios::binary);

src/cmake/CMakeBuild.cpp

@@ -545,58 +545,6 @@ namespace vix::cli::build
       currentProgressLine.clear();
     };
 
-    auto is_failed_line = [](const std::string &line) -> bool
-    {
-      return line.rfind("FAILED:", 0) == 0;
-    };
-
-    auto looks_like_live_error_line = [&](const std::string &line) -> bool
-    {
-      if (line.empty())
-        return false;
-
-      if (is_failed_line(line))
-        return true;
-
-      if (line.rfind("ninja:", 0) == 0)
-        return true;
-
-      if (line.find(": error:") != std::string::npos)
-        return true;
-
-      if (line.find(" error: ") != std::string::npos)
-        return true;
-
-      if (line.find("fatal error:") != std::string::npos)
-        return true;
-
-      if (line.find("undefined reference to") != std::string::npos)
-        return true;
-
-      if (line.find("collect2: error:") != std::string::npos)
-        return true;
-
-      if (line.find("ld: error:") != std::string::npos)
-        return true;
-
-      if (line.find("CMake Error") != std::string::npos)
-        return true;
-
-      if (line.rfind("-->", 0) == 0)
-        return true;
-
-      if (line == "code:")
-        return true;
-
-      if (line.rfind("hint:", 0) == 0)
-        return true;
-
-      if (line.rfind("at:", 0) == 0)
-        return true;
-
-      return false;
-    };
-
     auto should_echo_line = [&](const std::string &line) -> bool
     {
       if (quiet)

src/commands/replay/ReplayId.cpp

@@ -107,8 +107,10 @@ namespace vix::commands::replay
 
     std::uint64_t hash = offset;
 
-    for (unsigned char c : value)
+    for (char ch : value)
     {
+      const auto c = static_cast<unsigned char>(ch);
+
       hash ^= static_cast<std::uint64_t>(c);
       hash *= prime;
     }

src/commands/replay/ReplayPaths.cpp

@@ -90,12 +90,14 @@ namespace vix::commands::replay
     if (id.empty())
       return false;
 
-    for (unsigned char c : id)
+    for (char ch : id)
     {
+      const auto c = static_cast<unsigned char>(ch);
+
       const bool ok =
           std::isalnum(c) != 0 ||
-          c == '-' ||
-          c == '_';
+          ch == '-' ||
+          ch == '_';
 
       if (!ok)
         return false;

src/commands/replay/ReplayPrinter.cpp

@@ -26,10 +26,8 @@ using namespace vix::cli::style;
 
 namespace vix::commands::replay
 {
-
   namespace
   {
-
     /**
      * @brief Return a color for a replay status.
      *
@@ -124,18 +122,6 @@ namespace vix::commands::replay
         out << value << "\n";
     }
 
-    /**
-     * @brief Return the first non-empty string.
-     *
-     * @param first First value.
-     * @param second Fallback value.
-     * @return first if non-empty, otherwise second.
-     */
-    std::string non_empty_or(const std::string &first, const std::string &second)
-    {
-      return first.empty() ? second : first;
-    }
-
     /**
      * @brief Split a text into lines.
      *
@@ -156,7 +142,6 @@ namespace vix::commands::replay
 
       return lines;
     }
-
   } // namespace
 
   void print_replay_header(std::ostream &out, const ReplayRecord &record)