Skip to content

Commit 3dd63eb

Browse files
committed
fix(cli): detect websocket upgrade failures
2 parents 2c9349d + b09a38c commit 3dd63eb

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

src/commands/ws/WsChecker.cpp

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,13 @@ namespace vix::commands::ws::checker
481481
}
482482

483483
if (contains_text(message, "upgrade") ||
484-
contains_text(message, "sec-websocket-accept"))
484+
contains_text(message, "sec-websocket-accept") ||
485+
contains_text(message, "bad response") ||
486+
contains_text(message, "invalid response") ||
487+
contains_text(message, "expected 101") ||
488+
contains_text(message, "did not switch protocols") ||
489+
contains_text(message, "missing connection") ||
490+
contains_text(message, "missing upgrade"))
485491
{
486492
return WsFailureKind::MissingUpgrade;
487493
}
@@ -521,7 +527,7 @@ namespace vix::commands::ws::checker
521527
case WsFailureKind::Timeout:
522528
return "WebSocket connection timed out.";
523529
case WsFailureKind::MissingUpgrade:
524-
return "WebSocket upgrade headers are missing or invalid.";
530+
return "WebSocket upgrade failed.";
525531
case WsFailureKind::BadPath:
526532
return "WebSocket path does not exist on the server.";
527533
case WsFailureKind::ProxyHttpResponse:
@@ -548,7 +554,7 @@ namespace vix::commands::ws::checker
548554
case WsFailureKind::Timeout:
549555
return "check firewall, upstream and service";
550556
case WsFailureKind::MissingUpgrade:
551-
return "check Nginx Upgrade headers";
557+
return "check Upgrade and Connection headers";
552558
case WsFailureKind::BadPath:
553559
return "check WebSocket route/path";
554560
case WsFailureKind::ProxyHttpResponse:

0 commit comments

Comments
 (0)