bugfix (agent): fixes to agent/utils/download.go and agent/utils/req.go to close idle connections

osmontero · osmontero · commit 7fc5ee85e739 · 2026-02-10T13:53:41.000Z
diff --git a/agent/utils/download.go b/agent/utils/download.go
@@ -18,11 +18,12 @@ func DownloadFile(url string, headers map[string]string, fileName string, path s
 		req.Header.Add(key, value)
 	}
 
-	client := &http.Client{}
-	client.Transport = &http.Transport{
-		TLSClientConfig: &tls.Config{InsecureSkipVerify: skipTlsVerification},
+	tr := &http.Transport{
+		TLSClientConfig:    &tls.Config{InsecureSkipVerify: skipTlsVerification},
 		DisableCompression: true,
 	}
+	client := &http.Client{Transport: tr}
+	defer tr.CloseIdleConnections()
 
 	resp, err := client.Do(req)
 	if err != nil {
diff --git a/agent/utils/req.go b/agent/utils/req.go
@@ -21,10 +21,11 @@ func DoReq[response any](url string, data []byte, method string, headers map[str
 		req.Header.Add(k, v)
 	}
 
-	client := &http.Client{}
-	client.Transport = &http.Transport{
+	tr := &http.Transport{
 		TLSClientConfig: &tls.Config{InsecureSkipVerify: skipTlsVerification},
 	}
+	client := &http.Client{Transport: tr}
+	defer tr.CloseIdleConnections()
 
 	resp, err := client.Do(req)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -18,11 +18,12 @@ func DownloadFile(url string, headers map[string]string, fileName string, path s`
`18`	`18`	`req.Header.Add(key, value)`
`19`	`19`	`}`
`20`	`20`
`21`		`- client := &http.Client{}`
`22`		`- client.Transport = &http.Transport{`
`23`		`- TLSClientConfig: &tls.Config{InsecureSkipVerify: skipTlsVerification},`
	`21`	`+ tr := &http.Transport{`
	`22`	`+ TLSClientConfig: &tls.Config{InsecureSkipVerify: skipTlsVerification},`
`24`	`23`	`DisableCompression: true,`
`25`	`24`	`}`
	`25`	`+ client := &http.Client{Transport: tr}`
	`26`	`+ defer tr.CloseIdleConnections()`
`26`	`27`
`27`	`28`	`resp, err := client.Do(req)`
`28`	`29`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,11 @@ func DoReq[response any](url string, data []byte, method string, headers map[str`
`21`	`21`	`req.Header.Add(k, v)`
`22`	`22`	`}`
`23`	`23`
`24`		`- client := &http.Client{}`
`25`		`- client.Transport = &http.Transport{`
	`24`	`+ tr := &http.Transport{`
`26`	`25`	`TLSClientConfig: &tls.Config{InsecureSkipVerify: skipTlsVerification},`
`27`	`26`	`}`
	`27`	`+ client := &http.Client{Transport: tr}`
	`28`	`+ defer tr.CloseIdleConnections()`
`28`	`29`
`29`	`30`	`resp, err := client.Do(req)`
`30`	`31`	`if err != nil {`