Skip to content

Commit d7bd92d

Browse files
simplify, use methods from DatabaseTools
1 parent f661654 commit d7bd92d

File tree

1 file changed

+2
-16
lines changed

1 file changed

+2
-16
lines changed

sqldev/src/main/java/org/utplsql/sqldev/oddgen/TestGenerator.java

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import java.io.File;
1919
import java.sql.Connection;
20-
import java.sql.SQLException;
2120
import java.util.ArrayList;
2221
import java.util.Arrays;
2322
import java.util.HashMap;
@@ -30,7 +29,7 @@
3029
import org.oddgen.sqldev.generators.model.NodeTools;
3130
import org.oddgen.sqldev.plugin.templates.TemplateTools;
3231
import org.utplsql.sqldev.dal.UtplsqlDao;
33-
import org.utplsql.sqldev.exception.GenericDatabaseAccessException;
32+
import org.utplsql.sqldev.model.DatabaseTools;
3433
import org.utplsql.sqldev.model.oddgen.GenContext;
3534
import org.utplsql.sqldev.model.preference.PreferenceModel;
3635
import org.utplsql.sqldev.resources.UtplsqlResources;
@@ -129,20 +128,7 @@ private CharSequence deleteFiles(final String directory) {
129128

130129
@Override
131130
public boolean isSupported(final Connection conn) {
132-
try {
133-
boolean ret = false;
134-
if (conn != null && conn.getMetaData().getDatabaseProductName().startsWith("Oracle")
135-
&& (conn.getMetaData().getDatabaseMajorVersion() == 11
136-
&& conn.getMetaData().getDatabaseMinorVersion() >= 2
137-
|| conn.getMetaData().getDatabaseMajorVersion() > 11)) {
138-
ret = true;
139-
}
140-
return ret;
141-
} catch (SQLException e) {
142-
final String msg = "SQLException during connection check due to " + e.getMessage();
143-
logger.severe(() -> msg);
144-
throw new GenericDatabaseAccessException(msg, e);
145-
}
131+
return DatabaseTools.isSupported(conn);
146132
}
147133

148134
@Override

0 commit comments

Comments
 (0)