Skip to content

Commit 22c09cf

Browse files
use FileTools instead of Files
1 parent 1df2180 commit 22c09cf

File tree

2 files changed

+5
-26
lines changed

2 files changed

+5
-26
lines changed

sqldev/src/main/java/org/utplsql/sqldev/coverage/CodeCoverageReporter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.io.File;
2020
import java.net.URL;
2121
import java.nio.charset.StandardCharsets;
22-
import java.nio.file.Files;
2322
import java.sql.Connection;
2423
import java.sql.SQLException;
2524
import java.util.ArrayList;
@@ -30,6 +29,7 @@
3029
import org.utplsql.sqldev.dal.UtplsqlDao;
3130
import org.utplsql.sqldev.exception.GenericDatabaseAccessException;
3231
import org.utplsql.sqldev.exception.GenericRuntimeException;
32+
import org.utplsql.sqldev.model.FileTools;
3333
import org.utplsql.sqldev.ui.coverage.CodeCoverageReporterDialog;
3434

3535
import oracle.dbtools.raptor.utils.Connections;
@@ -103,7 +103,7 @@ private void run() {
103103
toStringList(includeObjects), toStringList(excludeObjects));
104104
final File file = File.createTempFile("utplsql_", ".html");
105105
logger.fine(() -> "Writing result to " + file + "...");
106-
Files.write(file.toPath(), Arrays.asList(content.split(System.lineSeparator())), StandardCharsets.UTF_8);
106+
FileTools.writeFile(file.toPath(), Arrays.asList(content.split(System.lineSeparator())), StandardCharsets.UTF_8);
107107
final URL url = file.toURI().toURL();
108108
logger.fine(() -> "Opening " + url.toExternalForm() + " in browser...");
109109
final Desktop desktop = Desktop.isDesktopSupported() ? Desktop.getDesktop() : null;

sqldev/src/main/java/org/utplsql/sqldev/snippet/SnippetMerger.java

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
import java.io.InputStreamReader;
2323
import java.io.StringReader;
2424
import java.nio.charset.Charset;
25-
import java.nio.file.Files;
26-
import java.nio.file.Path;
2725
import java.nio.file.Paths;
2826
import java.util.logging.Logger;
2927
import java.util.stream.Collectors;
@@ -34,6 +32,7 @@
3432
import javax.xml.parsers.ParserConfigurationException;
3533

3634
import org.utplsql.sqldev.exception.GenericRuntimeException;
35+
import org.utplsql.sqldev.model.FileTools;
3736
import org.utplsql.sqldev.model.XMLTools;
3837
import org.w3c.dom.Document;
3938
import org.w3c.dom.NodeList;
@@ -66,26 +65,6 @@ public SnippetMerger(final File file) {
6665
userSnippetsFile = file;
6766
}
6867

69-
private byte[] readFile(Path path) {
70-
try {
71-
return Files.readAllBytes(path);
72-
} catch (IOException e) {
73-
final String msg = "Cannot read file " + path.toString() + " due to " + e.getMessage() + ".";
74-
logger.severe(() -> msg);
75-
throw new GenericRuntimeException(msg, e);
76-
}
77-
}
78-
79-
private void writeFile(Path path, byte[] bytes) {
80-
try {
81-
Files.write(path, bytes);
82-
} catch (IOException e) {
83-
final String msg = "Cannot write file " + path.toString() + " due to " + e.getMessage() + ".";
84-
logger.severe(() -> msg);
85-
throw new GenericRuntimeException(msg, e);
86-
}
87-
}
88-
8968
private DocumentBuilder createDocumentBuilder() {
9069
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
9170
try {
@@ -112,7 +91,7 @@ public void merge() {
11291
String result = null;
11392
if (userSnippetsFile.exists()) {
11493
// file exists, proper merge required
115-
final String userSnippets = new String(readFile(Paths.get(userSnippetsFile.getAbsolutePath())));
94+
final String userSnippets = new String(FileTools.readFile(Paths.get(userSnippetsFile.getAbsolutePath())));
11695
final DocumentBuilder docBuilder = createDocumentBuilder();
11796
final Document userSnippetsDoc = parse(docBuilder, new InputSource(new StringReader(userSnippets)));
11897
final NodeList userSnippetsGroups = xmlTools.getNodeList(userSnippetsDoc,
@@ -138,7 +117,7 @@ public void merge() {
138117
// just copy
139118
result = utplsqlSnippets;
140119
}
141-
writeFile(Paths.get(userSnippetsFile.getAbsolutePath()), result.getBytes());
120+
FileTools.writeFile(Paths.get(userSnippetsFile.getAbsolutePath()), result.getBytes());
142121
}
143122

144123
public String getTemplate() {

0 commit comments

Comments
 (0)