Skip to content

Commit ecf8317

Browse files
committed
Don’t get all the columns for the query. Improved the logging.
1 parent b7b3bb0 commit ecf8317

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

apps/webapp/app/v3/services/resumeAttempt.server.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ export class ResumeAttemptService extends BaseService {
3939
include: {
4040
taskRun: true,
4141
dependencies: {
42-
include: {
42+
select: {
4343
taskRun: {
44-
include: {
44+
select: {
4545
attempts: latestAttemptSelect,
4646
},
4747
},
@@ -52,11 +52,11 @@ export class ResumeAttemptService extends BaseService {
5252
take: 1,
5353
},
5454
batchDependencies: {
55-
include: {
55+
select: {
5656
items: {
57-
include: {
57+
select: {
5858
taskRun: {
59-
include: {
59+
select: {
6060
attempts: latestAttemptSelect,
6161
},
6262
},
@@ -143,7 +143,13 @@ export class ResumeAttemptService extends BaseService {
143143
completedAttemptIds = finalAttempts.map((a) => a.id);
144144

145145
if (completedAttemptIds.length !== dependentBatchItems.length) {
146-
this._logger.error("[ResumeAttemptService] not all batch items have attempts");
146+
this._logger.error("[ResumeAttemptService] not all batch items have attempts", {
147+
runId: attempt.taskRunId,
148+
completedAttemptIds,
149+
finalAttempts,
150+
dependentBatchItems,
151+
});
152+
147153
return;
148154
}
149155
} else {

0 commit comments

Comments
 (0)