Show a separate spinner during deployment init

Author: myftija

packages/cli-v3/src/commands/deploy.ts

@@ -933,13 +933,13 @@ async function handleNativeBuildServerDeploy({
     );
   }
 
-  $deploymentSpinner.stop("Deployment files uploaded");
-
   const [unlinkError] = await tryCatch(unlink(archivePath));
   if (unlinkError) {
     logger.debug("Failed to delete deployment artifact file", { archivePath, error: unlinkError });
   }
 
+  $deploymentSpinner.message("Deployment files uploaded");
+
   const initializeDeploymentResult = await apiClient.initializeDeployment({
     contentHash: "-",
     userId,
@@ -952,7 +952,9 @@ async function handleNativeBuildServerDeploy({
   });
 
   if (!initializeDeploymentResult.success) {
-    throw new Error(`Failed to initialize deployment: ${initializeDeploymentResult.error}`);
+    $deploymentSpinner.stop("Failed to initialize deployment");
+    log.error(chalk.bold(chalkError(initializeDeploymentResult.error)));
+    throw new OutroCommandError(`Deployment failed`);
   }
 
   const deployment = initializeDeploymentResult.data;
@@ -962,6 +964,12 @@ async function handleNativeBuildServerDeploy({
     options.env === "prod" ? "prod" : "stg"
   }`;
 
+  const exposedDeploymentLink = isLinksSupported
+    ? cliLink(chalk.bold(rawDeploymentLink), rawDeploymentLink)
+    : chalk.bold(rawDeploymentLink);
+  $deploymentSpinner.stop("Deployment initialized");
+  log.info(`View deployment: ${exposedDeploymentLink}`);
+
   setGithubActionsOutputAndEnvVars({
     envVars: {
       TRIGGER_DEPLOYMENT_VERSION: deployment.version,
@@ -985,32 +993,18 @@ async function handleNativeBuildServerDeploy({
   if (!eventStream) {
     log.warn(`Failed streaming build logs, open the deployment in the dashboard to view the logs`);
 
-    if (!isLinksSupported) {
-      log.info(`View deployment: ${rawDeploymentLink}`);
-    }
-
-    outro(
-      `Version ${deployment.version} is being deployed ${
-        isLinksSupported ? `| ${cliLink("View deployment", rawDeploymentLink)}` : ""
-      }`
-    );
+    outro(`Version ${deployment.version} is being deployed`);
 
     process.exit(0);
   }
 
-  const exposedDeploymentLink = isLinksSupported
-    ? cliLink(chalk.bold(rawDeploymentLink), rawDeploymentLink)
-    : chalk.bold(rawDeploymentLink);
-  log.info(`View deployment: ${exposedDeploymentLink}`);
-
   const $queuedSpinner = spinner({
     cancelMessage:
       "Disconnecting from the build server log stream. If you intended to cancel the deployment instead, you can do that in the dashboard.",
   });
   $queuedSpinner.start("Build queued");
 
   const abortController = new AbortController();
-  let deploymentLog: ReturnType<typeof taskLog> | undefined;
 
   const s2 = new S2({ accessToken: eventStream.s2.accessToken });
   const basin = s2.basin(eventStream.s2.basin);

packages/cli-v3/src/deploy/buildImage.ts

@@ -484,7 +484,7 @@ async function localBuildImage(options: SelfHostedBuildImageOptions): Promise<Bu
       };
     }
 
-    options.onLog?.(`Successfully logged in to ${cloudRegistryHost}`);
+    options.onLog?.(`Successfully logged in to the remote registry`);
   }
 
   const projectCacheRef = getProjectCacheRefFromImageTag(imageTag);