fix(engine): add additional error logging around triggering runs (#3211)

Author: ericallam

apps/webapp/app/v3/runEngineHandlers.server.ts

@@ -759,6 +759,16 @@ export function setupBatchQueueCallbacks() {
             span.end();
             return { success: true as const, runId: result.run.friendlyId };
           } else {
+            logger.error("[BatchQueue] TriggerTaskService returned undefined", {
+              batchId,
+              friendlyId,
+              itemIndex,
+              task: item.task,
+              environmentId: meta.environmentId,
+              attempt,
+              isFinalAttempt,
+            });
+
             span.setAttribute("batch.result.error", "TriggerTaskService returned undefined");
 
             // Only create a pre-failed run on the final attempt; otherwise let the retry mechanism handle it
@@ -795,6 +805,18 @@ export function setupBatchQueueCallbacks() {
           }
         } catch (error) {
           const errorMessage = error instanceof Error ? error.message : String(error);
+
+          logger.error("[BatchQueue] Failed to trigger batch item", {
+            batchId,
+            friendlyId,
+            itemIndex,
+            task: item.task,
+            environmentId: meta.environmentId,
+            attempt,
+            isFinalAttempt,
+            error,
+          });
+
           span.setAttribute("batch.result.error", errorMessage);
           span.recordException(error instanceof Error ? error : new Error(String(error)));
 

internal-packages/run-engine/src/engine/index.ts

@@ -769,19 +769,32 @@ export class RunEngine {
             }
           }
         } else {
-          if (taskRun.ttl) {
-            await this.ttlSystem.scheduleExpireRun({ runId: taskRun.id, ttl: taskRun.ttl });
-          }
+          try {
+            if (taskRun.ttl) {
+              await this.ttlSystem.scheduleExpireRun({ runId: taskRun.id, ttl: taskRun.ttl });
+            }
 
-          await this.enqueueSystem.enqueueRun({
-            run: taskRun,
-            env: environment,
-            workerId,
-            runnerId,
-            tx: prisma,
-            skipRunLock: true,
-            includeTtl: true,
-          });
+            await this.enqueueSystem.enqueueRun({
+              run: taskRun,
+              env: environment,
+              workerId,
+              runnerId,
+              tx: prisma,
+              skipRunLock: true,
+              includeTtl: true,
+            });
+          } catch (enqueueError) {
+            this.logger.error("engine.trigger(): failed to schedule TTL or enqueue run", {
+              runId: taskRun.id,
+              friendlyId: taskRun.friendlyId,
+              taskIdentifier: taskRun.taskIdentifier,
+              environmentId: environment.id,
+              ttl: taskRun.ttl,
+              error: enqueueError,
+            });
+
+            throw enqueueError;
+          }
         }
 
         this.eventBus.emit("runCreated", {