remove crumbs

Author: ericallam

packages/cli-v3/src/dev/backgroundWorker.ts

@@ -6,8 +6,6 @@ import { prettyError } from "../utilities/cliOutput.js";
 import { writeJSONFile } from "../utilities/fileSystem.js";
 import { logger } from "../utilities/logger.js";
 import type { Metafile } from "esbuild";
-import { trail } from "agentcrumbs"; // @crumbs
-const crumb = trail("cli"); // @crumbs
 
 export type BackgroundWorkerOptions = {
   env: Record<string, string>;
@@ -39,7 +37,6 @@ export class BackgroundWorker {
   }
 
   stop() {
-    crumb("BackgroundWorker.stop", { version: this.serverWorker?.version, outputPath: this.build.outputPath }); // @crumbs
     logger.debug("[BackgroundWorker] Stopping worker", {
       version: this.serverWorker?.version,
       outputPath: this.build.outputPath,

packages/cli-v3/src/dev/devSession.ts

@@ -28,8 +28,6 @@ import {
 import { startDevOutput } from "./devOutput.js";
 import { startWorkerRuntime } from "./devSupervisor.js";
 import { startMcpServer, stopMcpServer } from "./mcpServer.js";
-import { trail } from "agentcrumbs"; // @crumbs
-const crumb = trail("cli"); // @crumbs
 import { writeJSONFile } from "../utilities/fileSystem.js";
 import { join } from "node:path";
 
@@ -61,7 +59,6 @@ export async function startDevSession({
   const destination = getTmpDir(rawConfig.workingDir, "build", keepTmpFiles);
   // Create shared store directory for deduplicating chunk files across rebuilds
   const storeDir = getStoreDir(rawConfig.workingDir, keepTmpFiles);
-  crumb("devSession started", { destinationPath: destination.path, storeDir, workingDir: rawConfig.workingDir }); // @crumbs
 
   const runtime = await startWorkerRuntime({
     name,
@@ -104,7 +101,6 @@ export async function startDevSession({
   const pluginsFromExtensions = resolvePluginsForContext(buildContext);
 
   async function updateBundle(bundle: BundleResult, workerDir?: EphemeralDirectory) {
-    crumb("updateBundle", { isRebuild: !!workerDir, workerDirPath: workerDir?.path, destinationPath: destination.path }); // @crumbs
     let buildManifest = await createBuildManifestFromBundle({
       bundle,
       destination: destination.path,
@@ -185,7 +181,6 @@ export async function startDevSession({
         }
 
         const workerDir = getTmpDir(rawConfig.workingDir, "build", keepTmpFiles);
-        crumb("rebuild: new workerDir", { path: workerDir.path }); // @crumbs
         await updateBuild(result, workerDir);
       });
     },
@@ -229,7 +224,6 @@ export async function startDevSession({
 
   return {
     stop: () => {
-      crumb("devSession stopping", { destinationPath: destination.path }); // @crumbs
       logger.debug("Stopping dev session");
 
       destination.remove();

packages/cli-v3/src/dev/devSupervisor.ts

@@ -28,8 +28,6 @@ import {
 } from "@trigger.dev/core/v3/workers";
 import pLimit from "p-limit";
 import { resolveLocalEnvVars } from "../utilities/localEnvVars.js";
-import { trail } from "agentcrumbs"; // @crumbs
-const crumb = trail("cli"); // @crumbs
 import type { Metafile } from "esbuild";
 import { TaskRunProcessPool } from "./taskRunProcessPool.js";
 import { tryCatch } from "@trigger.dev/core/utils";
@@ -435,8 +433,6 @@ class DevSupervisor implements WorkerRuntime {
       for (const message of result.data.dequeuedMessages) {
         const worker = this.workers.get(message.backgroundWorker.friendlyId);
 
-        crumb("dequeue run", { runId: message.run.friendlyId, targetWorkerId: message.backgroundWorker.friendlyId, workerFound: !!worker, workerDeprecated: worker?.deprecated, availableWorkers: Array.from(this.workers.keys()) }); // @crumbs
-
         if (!worker) {
           logger.debug(
             `[DevSupervisor] dequeueRuns. Dequeued a run but there's no BackgroundWorker so we can't execute it`,
@@ -510,7 +506,6 @@ class DevSupervisor implements WorkerRuntime {
           taskRunProcessPool: this.taskRunProcessPool,
           cwd,
           onFinished: () => {
-            crumb("run finished", { runId: message.run.friendlyId, workerId: message.backgroundWorker.friendlyId, workerDeprecated: worker.deprecated }); // @crumbs
 
             logger.debug("[DevSupervisor] Run finished", { runId: message.run.friendlyId });
 
@@ -522,7 +517,6 @@ class DevSupervisor implements WorkerRuntime {
 
             //stop the worker if it is deprecated and there are no more runs
             if (worker.deprecated) {
-              crumb("run finished on deprecated worker, scheduling cleanup", { workerId: message.backgroundWorker.friendlyId }); // @crumbs
               this.#tryDeleteWorker(message.backgroundWorker.friendlyId).finally(() => {});
             }
           },
@@ -613,15 +607,12 @@ class DevSupervisor implements WorkerRuntime {
       return;
     }
 
-    crumb("registerWorker", { newWorkerId: worker.serverWorker.id, version: worker.serverWorker.version, existingWorkers: Array.from(this.workers.keys()) }); // @crumbs
-
     //deprecate other workers
     for (const [workerId, existingWorker] of this.workers.entries()) {
       if (workerId === worker.serverWorker.id) {
         continue;
       }
 
-      crumb("deprecating worker", { workerId, hasActiveRuns: Array.from(this.runControllers.values()).some(c => { try { return c.workerFriendlyId === workerId; } catch { return false; } }) }); // @crumbs
       existingWorker.deprecate();
       this.#tryDeleteWorker(workerId).finally(() => {});
     }
@@ -750,23 +741,17 @@ class DevSupervisor implements WorkerRuntime {
   static readonly MAX_DEPRECATED_WORKERS = 2;
 
   async #tryDeleteWorker(friendlyId: string) {
-    crumb("tryDeleteWorker: waiting 5s", { friendlyId }); // @crumbs
     await awaitTimeout(5_000);
     this.#cleanupWorker(friendlyId);
   }
 
   #cleanupWorker(friendlyId: string) {
     const worker = this.workers.get(friendlyId);
     if (!worker) {
-      crumb("cleanupWorker: worker not found in map", { friendlyId }); // @crumbs
       return;
     }
 
     // Check if any active runs still reference this worker
-    const activeRunIds = Array.from(this.runControllers.entries()).filter(([, c]) => { try { return c.workerFriendlyId === friendlyId; } catch { return false; } }).map(([id]) => id); // @crumbs
-    const hasActiveRuns = activeRunIds.length > 0; // @crumbs
-
-    crumb("cleanupWorker", { friendlyId, hasActiveRuns, activeRunIds, version: worker.serverWorker?.version, outputPath: worker.build.outputPath }); // @crumbs
 
     if (hasActiveRuns) {
       logger.debug("[DevSupervisor] Worker still has active runs, skipping cleanup", {
@@ -804,8 +789,6 @@ class DevSupervisor implements WorkerRuntime {
       }
     }
 
-    crumb("pruneDeprecatedWorkers", { total: deprecatedWorkers.length, max: DevSupervisor.MAX_DEPRECATED_WORKERS, ids: deprecatedWorkers.map(w => w.id) }); // @crumbs
-
     // Keep the most recent deprecated workers, remove the rest
     if (deprecatedWorkers.length <= DevSupervisor.MAX_DEPRECATED_WORKERS) {
       return;
@@ -818,7 +801,6 @@ class DevSupervisor implements WorkerRuntime {
     );
 
     for (const { id, worker } of toRemove) {
-      crumb("pruning worker", { id, version: worker.serverWorker?.version, outputPath: worker.build.outputPath }); // @crumbs
 
       logger.debug("[DevSupervisor] Pruning old deprecated worker and cleaning up build dir", {
         workerId: id,

packages/cli-v3/src/dev/devWatchdog.ts

@@ -21,8 +21,6 @@
 import { readFileSync, writeFileSync, unlinkSync, existsSync, mkdirSync, rmSync } from "node:fs";
 import { dirname } from "node:path";
 // @crumbs - watchdog runs as detached process, trail imported directly
-let crumb: (msg: string, data?: Record<string, unknown>) => void = () => {}; // @crumbs
-try { const { trail } = await import("agentcrumbs"); crumb = trail("cli"); } catch {} // @crumbs
 
 const POLL_INTERVAL_MS = 1000;
 
@@ -81,12 +79,9 @@ function cleanup() {
 
 function cleanupTmpDir() {
   if (!tmpDir) return;
-  crumb("watchdog: cleaning up tmp dir", { tmpDir }); // @crumbs
   try {
     rmSync(tmpDir, { recursive: true, force: true });
-    crumb("watchdog: tmp dir removed", { tmpDir }); // @crumbs
   } catch {
-    crumb("watchdog: tmp dir cleanup failed", { tmpDir }); // @crumbs
     // Best effort — may fail on Windows with EBUSY
   }
 }
@@ -129,7 +124,6 @@ const MAX_DISCONNECT_ATTEMPTS = 5;
 const INITIAL_BACKOFF_MS = 500;
 
 async function onParentDied(): Promise<void> {
-  crumb("watchdog: parent died", { parentPid, tmpDir }); // @crumbs
   const runFriendlyIds = readActiveRuns();
 
   if (runFriendlyIds.length > 0) {