Skip to content

Commit aa69b90

Browse files
authored
fix(repo): undo node.js supervisor upgrades and use the multiplatform node.js digest in Dockerfile (#2895)
1 parent 0b0df07 commit aa69b90

File tree

4 files changed

+12
-3
lines changed

4 files changed

+12
-3
lines changed

CLAUDE.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,15 @@ For testable code, **never import env.server.ts** in test files. Pass configurat
133133

134134
The codebase is transitioning from the "legacy run engine" (spread across codebase) to "Run Engine 2.0" (`@internal/run-engine`). Focus on Run Engine 2.0 for new work.
135135

136+
## Docker Image Guidelines
137+
138+
When updating Docker image references in `docker/Dockerfile` or other container files:
139+
140+
- **Always use multiplatform/index digests**, not architecture-specific digests
141+
- Architecture-specific digests (e.g., for `linux/amd64` only) will cause CI failures on different build environments
142+
- On Docker Hub, the multiplatform digest is shown on the main image page, while architecture-specific digests are listed under "OS/ARCH"
143+
- Example: Use `node:20.20-bullseye-slim@sha256:abc123...` where the digest is from the multiplatform index, not from a specific OS/ARCH variant
144+
136145
## Database Migrations (PostgreSQL)
137146

138147
1. Edit `internal-packages/database/prisma/schema.prisma`

apps/supervisor/.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v22.22.0
1+
v22.12.0

apps/supervisor/Containerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:22.22.0-alpine@sha256:bcccf7410b77ca7447d292f616c7b0a89deff87e335fe91352ea04ce8babf50f AS node-22-alpine
1+
FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS node-22-alpine
22

33
WORKDIR /app
44

docker/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ARG NODE_IMAGE=node:20.20.0-bullseye-slim@sha256:f52726bba3d47831859be141b4a57d3f7b93323f8fddfbd8375386e2c3b72319
1+
ARG NODE_IMAGE=node:20.20-bullseye-slim@sha256:d6c3903e556d4161f63af4550e76244908b6668e1a7d2983eff4873a0c2b0413
22

33
FROM golang:1.23-alpine AS goose_builder
44
RUN go install github.com/pressly/goose/v3/cmd/goose@latest

0 commit comments

Comments
 (0)