Use allSettled so onWait/onResume errors don't break anything

ericallam · ericallam · commit 1def8d06c249 · 2025-03-25T16:32:17.000Z
diff --git a/packages/core/src/v3/lifecycleHooks/manager.ts b/packages/core/src/v3/lifecycleHooks/manager.ts
@@ -67,15 +67,15 @@ export class StandardLifecycleHooksManager implements LifecycleHooksManager {
   }
 
   async callOnWaitHookListeners(wait: TaskWait): Promise<void> {
-    await Promise.all(this.onWaitHookListeners.map((listener) => listener(wait)));
+    await Promise.allSettled(this.onWaitHookListeners.map((listener) => listener(wait)));
   }
 
   registerOnResumeHookListener(listener: (wait: TaskWait) => Promise<void>): void {
     this.onResumeHookListeners.push(listener);
   }
 
   async callOnResumeHookListeners(wait: TaskWait): Promise<void> {
-    await Promise.all(this.onResumeHookListeners.map((listener) => listener(wait)));
+    await Promise.allSettled(this.onResumeHookListeners.map((listener) => listener(wait)));
   }
 
   registerGlobalStartHook(hook: RegisterHookFunctionParams<AnyOnStartHookFunction>): void {

Original file line number	Diff line number	Diff line change
`@@ -67,15 +67,15 @@ export class StandardLifecycleHooksManager implements LifecycleHooksManager {`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`async callOnWaitHookListeners(wait: TaskWait): Promise<void> {`
`70`		`- await Promise.all(this.onWaitHookListeners.map((listener) => listener(wait)));`
	`70`	`+ await Promise.allSettled(this.onWaitHookListeners.map((listener) => listener(wait)));`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`registerOnResumeHookListener(listener: (wait: TaskWait) => Promise<void>): void {`
`74`	`74`	`this.onResumeHookListeners.push(listener);`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`async callOnResumeHookListeners(wait: TaskWait): Promise<void> {`
`78`		`- await Promise.all(this.onResumeHookListeners.map((listener) => listener(wait)));`
	`78`	`+ await Promise.allSettled(this.onResumeHookListeners.map((listener) => listener(wait)));`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`registerGlobalStartHook(hook: RegisterHookFunctionParams<AnyOnStartHookFunction>): void {`