Skip to content

Commit 55ca46a

Browse files
committed
Fixed cloning buffers in the FlowStream (critical).
1 parent 764e4c5 commit 55ca46a

2 files changed

Lines changed: 5 additions & 16 deletions

File tree

changelog.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
========================
44

55
- fixed `Message-ID` generator for email messages
6+
- __critital__ fixed cloning buffers in the `FlowStream`
67

78
========================
89
0.0.98

flowstream.js

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -438,14 +438,8 @@ MP.send = function(outputindex, data, clonedata) {
438438
if (data != undefined)
439439
message.data = data;
440440

441-
if (clonedata && message.data && typeof(message.data) === 'object') {
442-
if (message.data instanceof Buffer) {
443-
var buf = Buffer.alloc(message.data.length);
444-
buf.copy(message.data);
445-
message.data = buf;
446-
} else
447-
message.data = U.clone(message.data);
448-
}
441+
if (clonedata && message.data && typeof(message.data) === 'object')
442+
message.data = message.data instanceof Buffer ? Buffer.from(message.data) : U.clone(message.data);
449443

450444
message.used++;
451445
message.instance = schema;
@@ -1114,14 +1108,8 @@ FP.ontrigger = function(outputindex, data, controller, events) {
11141108
message.used = 1;
11151109
}
11161110

1117-
if (i && (self.cloning != false) && message.data && typeof(message.data) === 'object') {
1118-
if (message.data instanceof Buffer) {
1119-
var buf = Buffer.alloc(message.data.length);
1120-
buf.copy(message.data);
1121-
message.data = buf;
1122-
} else
1123-
message.data = U.clone(message.data);
1124-
}
1111+
if (i && (self.cloning != false) && message.data && typeof(message.data) === 'object')
1112+
message.data = message.data instanceof Buffer ? Buffer.from(message.data) : U.clone(message.data);
11251113

11261114
message.main = self;
11271115
message.controller = controller;

0 commit comments

Comments
 (0)