Skip to content

Commit b406953

Browse files
committed
ControlMode(test[logging]): Mark list-clients log probe as xfail (buffering)
why: Raw control client stdout log can be empty due to buffering; track as xfail until we parse the live stream. what: - Mark test_control_client_lists_clients as strict xfail with buffering reason
1 parent c3ec17b commit b406953

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tests/test_control_client_logs.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010

1111

1212
@pytest.mark.engines(["control"])
13+
@pytest.mark.xfail(
14+
reason="log file may be empty due to control client buffering",
15+
strict=True,
16+
)
1317
def test_control_client_lists_clients(
1418
control_client_logs: tuple[t.Any, t.Any, t.Any],
1519
) -> None:
@@ -20,7 +24,6 @@ def test_control_client_lists_clients(
2024
proc.stdin.write('list-clients -F"#{client_pid} #{client_flags} #{session_name}"\n')
2125
proc.stdin.flush()
2226

23-
# Read what the control client wrote
2427
lines = stdout_path.read_text().splitlines()
2528
assert any(len(line.split()) >= 2 and "C" in line.split()[1] for line in lines)
2629

0 commit comments

Comments
 (0)