audio: volume: Memory, blob, and fast_get allocs to module API

Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches.

When resources are allocated through module API functions they
are automatically freed when the module is unloaded. This
simplifies error handling and unloading process.

Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Author: Jyri Sarha

src/audio/volume/volume.c

@@ -24,7 +24,6 @@
 #include <sof/common.h>
 #include <rtos/panic.h>
 #include <sof/ipc/msg.h>
-#include <rtos/alloc.h>
 #include <rtos/init.h>
 #include <sof/lib/cpu.h>
 #include <sof/lib/uuid.h>
@@ -775,11 +774,7 @@ static int volume_free(struct processing_module *mod)
 	struct vol_data *cd = module_get_private_data(mod);
 
 	comp_dbg(mod->dev, "volume_free()");
-
 	volume_peak_free(cd);
-	rfree(cd->vol);
-	rfree(cd);
-
 	return 0;
 }
 

src/audio/volume/volume_ipc3.c

@@ -14,7 +14,6 @@
 #include <sof/common.h>
 #include <rtos/panic.h>
 #include <sof/ipc/msg.h>
-#include <rtos/alloc.h>
 #include <rtos/init.h>
 #include <sof/lib/cpu.h>
 #include <sof/lib/uuid.h>
@@ -81,17 +80,16 @@ int volume_init(struct processing_module *mod)
 		return -EINVAL;
 	}
 
-	cd = rzalloc(SOF_MEM_FLAG_USER, sizeof(struct vol_data));
+	cd = mod_zalloc(mod, sizeof(struct vol_data));
 	if (!cd)
 		return -ENOMEM;
 
 	/*
 	 * malloc memory to store current volume 4 times to ensure the address
 	 * is 8-byte aligned for multi-way xtensa intrinsic operations.
 	 */
-	cd->vol = rmalloc(SOF_MEM_FLAG_USER, vol_size);
+	cd->vol = mod_alloc(mod, vol_size);
 	if (!cd->vol) {
-		rfree(cd);
 		comp_err(dev, "Failed to allocate %zu", vol_size);
 		return -ENOMEM;
 	}
@@ -158,8 +156,6 @@ int volume_init(struct processing_module *mod)
 		break;
 	default:
 		comp_err(dev, "invalid ramp type %d", vol->ramp);
-		rfree(cd);
-		rfree(cd->vol);
 		return -EINVAL;
 	}
 

src/audio/volume/volume_ipc4.c

@@ -14,7 +14,6 @@
 #include <sof/common.h>
 #include <rtos/panic.h>
 #include <sof/ipc/msg.h>
-#include <rtos/alloc.h>
 #include <rtos/init.h>
 #include <sof/lib/cpu.h>
 #include <sof/lib/uuid.h>
@@ -128,28 +127,25 @@ int volume_init(struct processing_module *mod)
 		return -EINVAL;
 	}
 
-	cd = rzalloc(SOF_MEM_FLAG_USER, sizeof(struct vol_data));
+	cd = mod_zalloc(mod, sizeof(struct vol_data));
 	if (!cd)
 		return -ENOMEM;
 
 	/*
 	 * malloc memory to store current volume 4 times to ensure the address
 	 * is 8-byte aligned for multi-way xtensa intrinsic operations.
 	 */
-	cd->vol = rmalloc(SOF_MEM_FLAG_USER, vol_size);
+	cd->vol = mod_alloc(mod, vol_size);
 	if (!cd->vol) {
-		rfree(cd);
 		comp_err(dev, "Failed to allocate %d", vol_size);
 		return -ENOMEM;
 	}
 
 	/* malloc memory to store temp peak volume 4 times to ensure the address
 	 * is 8-byte aligned for multi-way xtensa intrinsic operations.
 	 */
-	cd->peak_vol = rzalloc(SOF_MEM_FLAG_USER, vol_size);
+	cd->peak_vol = mod_zalloc(mod, vol_size);
 	if (!cd->peak_vol) {
-		rfree(cd->vol);
-		rfree(cd);
 		comp_err(dev, "Failed to allocate %d for peak_vol", vol_size);
 		return -ENOMEM;
 	}
@@ -196,7 +192,6 @@ void volume_peak_free(struct vol_data *cd)
 	/* clear mailbox */
 	memset_s(&regs, sizeof(regs), 0, sizeof(regs));
 	mailbox_sw_regs_write(cd->mailbox_offset, &regs, sizeof(regs));
-	rfree(cd->peak_vol);
 }
 
 static int volume_set_volume(struct processing_module *mod, const uint8_t *data, int data_size)