Audio: MFCC: Fix error handling in mfcc_setup

Add missing cleanup for fft_plan. After mod_fft_plan_new() succeeds,
failures in window setup and mel filterbank initialization jumped to
free_fft_out, leaking the fft_plan. Add free_fft_plan label and route
these error paths through it.

Add missing cleanup for lifter.matrix. Late validation checks
(mel_log_32 space, output capacity) jumped to free_dct_matrix,
skipping the lifter matrix that may have been allocated. Add
free_lifter label for these paths.

Replace rfree() with mod_free() in all error cleanup labels to match
the mod_zalloc() allocations and the existing mfcc_free_buffers()
implementation.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

Author: singalsu

src/audio/mfcc/mfcc_setup.c

@@ -226,7 +226,7 @@ int mfcc_setup(struct processing_module *mod, int max_frames, int sample_rate, i
 	ret = mfcc_get_window(state, config->window);
 	if (ret < 0) {
 		comp_err(dev, "Failed Window function");
-		goto free_fft_out;
+		goto free_fft_plan;
 	}
 
 	/* Setup Mel auditory filterbank. FFT input and output buffers are used
@@ -248,7 +248,7 @@ int mfcc_setup(struct processing_module *mod, int max_frames, int sample_rate, i
 	ret = mod_psy_get_mel_filterbank(mod, fb);
 	if (ret < 0) {
 		comp_err(dev, "Failed Mel filterbank");
-		goto free_fft_out;
+		goto free_fft_plan;
 	}
 
 	/* Setup DCT and cepstral lifter only when num_ceps > 0.
@@ -313,7 +313,7 @@ int mfcc_setup(struct processing_module *mod, int max_frames, int sample_rate, i
 		comp_err(dev, "num_mel_bins %d exceeds mel_log_32 scratch space %d",
 			 config->num_mel_bins, mel_log_32_space);
 		ret = -EINVAL;
-		goto free_dct_matrix;
+		goto free_lifter;
 	}
 
 	state->mel_spectra = (struct mat_matrix_16b *)&fft->fft_out[0];
@@ -342,7 +342,7 @@ int mfcc_setup(struct processing_module *mod, int max_frames, int sample_rate, i
 		comp_err(dev, "Output %d int16 per hop exceeds sink capacity %d (hop %d x ch %d)",
 			 out_per_hop, sink_per_hop, fft->fft_hop_size, channels);
 		ret = -EINVAL;
-		goto free_dct_matrix;
+		goto free_lifter;
 	}
 
 	/* Set initial state for STFT */
@@ -356,20 +356,26 @@ int mfcc_setup(struct processing_module *mod, int max_frames, int sample_rate, i
 	comp_dbg(dev, "done");
 	return 0;
 
+free_lifter:
+	mod_free(mod, state->lifter.matrix);
+
 free_dct_matrix:
-	rfree(state->dct.matrix);
+	mod_free(mod, state->dct.matrix);
 
 free_melfb_data:
-	rfree(fb->data);
+	mod_free(mod, fb->data);
+
+free_fft_plan:
+	mod_fft_plan_free(mod, fft->fft_plan);
 
 free_fft_out:
-	rfree(fft->fft_out);
+	mod_free(mod, fft->fft_out);
 
 free_fft_buf:
-	rfree(fft->fft_buf);
+	mod_free(mod, fft->fft_buf);
 
 free_buffers:
-	rfree(state->buffers);
+	mod_free(mod, state->buffers);
 
 exit:
 	return ret;