audio: module_adapter: Remove use of comp_verify_params for IPC4

comp_verify_params does 3 things, update comp params based on buffer
flags, then set buffer params based on comp params and then finally set
the component period frames based on buffer frames. In the case of
IPC4, buffer flags are unused, so there's no need to update comp params
based on these flags. So, move the setting of buffer params during the
modules binding call where the buffers are allocated. Finally, set the
component period frames based on the module's params during module init.

Also, modify the allocation of the stream_params for the module to
include the SOF_MEM_FLAG_COHERENT flag to make sure that the memory is
coherent across cores when the stream_params are accessed during the
bind operation.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

Author: ranj063

src/audio/module_adapter/module_adapter.c

@@ -155,6 +155,9 @@ struct comp_dev *module_adapter_new_ext(const struct comp_driver *drv,
 		comp_err(dev, "%d: module params failed", ret);
 		goto err;
 	}
+
+	/* set component period frames */
+	component_set_nearest_period_frames(dev, params.rate);
 #endif
 
 	comp_dbg(dev, "done");
@@ -215,11 +218,7 @@ int module_adapter_prepare(struct comp_dev *dev)
 
 	comp_dbg(dev, "start");
 #if CONFIG_IPC_MAJOR_4
-	/*
-	 * if the stream_params are valid, just update the sink/source buffer params. If not,
-	 * retrieve the params from the basecfg, allocate stream_params and then update the
-	 * sink/source buffer params.
-	 */
+	/* allocate stream_params and retrieve the params from the basecfg if needed */
 	if (!mod->stream_params) {
 		struct sof_ipc_stream_params params;
 
@@ -228,12 +227,6 @@ int module_adapter_prepare(struct comp_dev *dev)
 			comp_err(dev, "module_adapter_new() %d: module params failed", ret);
 			return ret;
 		}
-	} else {
-		ret = comp_verify_params(dev, mod->verify_params_flags, mod->stream_params);
-		if (ret < 0) {
-			comp_err(dev, "comp_verify_params() failed.");
-			return ret;
-		}
 	}
 #endif
 	/* Prepare module */
@@ -524,17 +517,19 @@ int module_adapter_params(struct comp_dev *dev, struct sof_ipc_stream_params *pa
 
 	module_adapter_set_params(mod, params);
 
+#if CONFIG_IPC_MAJOR_3
 	ret = comp_verify_params(dev, mod->verify_params_flags, params);
 	if (ret < 0) {
 		comp_err(dev, "comp_verify_params() failed.");
 		return ret;
 	}
+#endif
 
 	/* allocate stream_params each time */
 	if (mod->stream_params)
 		rfree(mod->stream_params);
 
-	mod->stream_params = rzalloc(SOF_MEM_FLAG_USER,
+	mod->stream_params = rzalloc(SOF_MEM_FLAG_USER | SOF_MEM_FLAG_COHERENT,
 				     sizeof(*mod->stream_params) + params->ext_data_length);
 	if (!mod->stream_params)
 		return -ENOMEM;

src/ipc/ipc4/helper.c

@@ -683,6 +683,23 @@ __cold int ipc_comp_connect(struct ipc *ipc, ipc_pipe_comp_connect *_connect)
 		source->direction_set = true;
 	}
 
+	/* set sink buffer params for playback and source buffer params for capture */
+	if (source->direction == SOF_IPC_STREAM_PLAYBACK &&
+	    source->drv->type == SOF_COMP_MODULE_ADAPTER) {
+		struct processing_module *srcmod = comp_mod(source);
+
+		buffer_set_params(buffer, srcmod->stream_params, BUFFER_UPDATE_FORCE);
+		goto out;
+	}
+
+	if (sink->direction == SOF_IPC_STREAM_CAPTURE &&
+	    sink->drv->type == SOF_COMP_MODULE_ADAPTER) {
+		struct processing_module *sinkmod = comp_mod(sink);
+
+		buffer_set_params(buffer, sinkmod->stream_params, BUFFER_UPDATE_FORCE);
+	}
+
+out:
 	ll_unblock(cross_core_bind, flags);
 
 	return IPC4_SUCCESS;