Add feature to easily use a custom encoder. #439
+47
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deluxetom
approved these changes
Dec 8, 2025
piotr-cz
reviewed
Dec 8, 2025
| $this->setImageManager($imageManager); | ||
| $this->setManipulators($manipulators); | ||
| $this->setApiParams(); | ||
| $this->encoder = $encoder; |
Contributor
There was a problem hiding this comment.
I wonder, why not using setter like for other constructor parameters?
$this->setEncoder($encoder);
Collaborator
Author
There was a problem hiding this comment.
why not using setter like for other constructor parameters
Because the setter doesn't accept a null value. Ideally the constructor too shouldn't accept a null value since an encoder isn't optional, but I did it to avoid any problems for existing users who might have overridden Encoder's constructor.
Contributor
|
Thanks, this works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #436