fix tracing project

Author: xumaple

langsmith_tracing/basic/starter.py

@@ -11,6 +11,8 @@
 
 from langsmith_tracing.basic.workflows import BasicLLMWorkflow
 
+PROJECT_NAME = "langsmith-basic"
+
 
 async def main():
     add_temporal_runs = "--add-temporal-runs" in sys.argv
@@ -19,7 +21,7 @@ async def main():
     config.setdefault("target_host", "localhost:7233")
 
     plugin = LangSmithPlugin(
-        project_name="langsmith-basic",
+        project_name=PROJECT_NAME,
         add_temporal_runs=add_temporal_runs,
     )
 
@@ -29,9 +31,15 @@ async def main():
         plugins=[plugin],
     )
 
-    # Client-side @traceable wraps the entire workflow call, creating a
-    # root span in LangSmith that the workflow and activity traces nest under.
-    @traceable(name="Basic LLM Request", run_type="chain", tags=["client-side"])
+    @traceable(
+        name="Basic LLM Request",
+        run_type="chain",
+        # CRITICAL: Client-side @traceable runs outside the LangSmithPlugin's scope.
+        # Make sure client-side traces use the same project_name as what is given to
+        # # the plugin.
+        project_name=PROJECT_NAME,
+        tags=["client-side"],
+    )
     async def run_workflow(prompt: str) -> str:
         return await client.execute_workflow(
             BasicLLMWorkflow.run,

langsmith_tracing/basic/worker.py

@@ -26,22 +26,22 @@ async def main():
     config = ClientConfig.load_client_connect_config()
     config.setdefault("target_host", "localhost:7233")
 
-    client = await Client.connect(
-        **config,
-        data_converter=pydantic_data_converter,
-    )
-
     plugin = LangSmithPlugin(
         project_name="langsmith-basic",
         add_temporal_runs=add_temporal_runs,
     )
 
+    client = await Client.connect(
+        **config,
+        data_converter=pydantic_data_converter,
+        plugins=[plugin],
+    )
+
     async with Worker(
         client,
         task_queue="langsmith-basic-task-queue",
         workflows=[BasicLLMWorkflow],
         activities=[call_openai],
-        plugins=[plugin],
     ):
         label = "with" if add_temporal_runs else "without"
         print(f"Worker started ({label} Temporal runs in traces), ctrl+c to exit")

langsmith_tracing/chatbot/starter.py

@@ -5,7 +5,6 @@
 import sys
 import uuid
 
-import langsmith as ls
 from langsmith import traceable
 from temporalio.client import Client
 from temporalio.contrib.langsmith import LangSmithPlugin
@@ -14,6 +13,8 @@
 
 from langsmith_tracing.chatbot.workflows import ChatbotWorkflow
 
+PROJECT_NAME = "langsmith-chatbot"
+
 
 async def main():
     add_temporal_runs = "--add-temporal-runs" in sys.argv
@@ -22,7 +23,7 @@ async def main():
     config.setdefault("target_host", "localhost:7233")
 
     plugin = LangSmithPlugin(
-        project_name="langsmith-chatbot",
+        project_name=PROJECT_NAME,
         add_temporal_runs=add_temporal_runs,
     )
 
@@ -34,11 +35,13 @@ async def main():
 
     wf_id = f"langsmith-chatbot-{uuid.uuid4().hex[:8]}"
 
-    # Client-side trace wraps the full interactive session. Each turn
-    # (signal + query poll) nests under this root span in LangSmith.
     @traceable(
         name=f"Chatbot Session {wf_id[-8:]}",
         run_type="chain",
+        # CRITICAL: Client-side @traceable runs outside the LangSmithPlugin's scope.
+        # Make sure client-side traces use the same project_name as what is given to
+        # # the plugin.
+        project_name=PROJECT_NAME,
         tags=["client-side", "chatbot"],
     )
     async def run_session():
@@ -83,10 +86,7 @@ async def send_and_wait(msg: str):
             else:
                 print("(timed out waiting for response)")
 
-    try:
-        await run_session()
-    finally:
-        ls.flush()
+    await run_session()
 
 
 if __name__ == "__main__":

langsmith_tracing/chatbot/worker.py

@@ -13,8 +13,6 @@
 from langsmith_tracing.chatbot.activities import call_openai
 from langsmith_tracing.chatbot.workflows import ChatbotWorkflow
 
-interrupt_event = asyncio.Event()
-
 
 async def main():
     logging.basicConfig(level=logging.INFO)
@@ -27,30 +25,25 @@ async def main():
     client = await Client.connect(
         **config,
         data_converter=pydantic_data_converter,
+        plugins=[
+            LangSmithPlugin(
+                project_name="langsmith-chatbot",
+                add_temporal_runs=add_temporal_runs,
+            )
+        ],
     )
 
-    plugin = LangSmithPlugin(
-        project_name="langsmith-chatbot",
-        add_temporal_runs=add_temporal_runs,
-    )
-
-    async with Worker(
+    worker = Worker(
         client,
         task_queue="langsmith-chatbot-task-queue",
         workflows=[ChatbotWorkflow],
         activities=[call_openai],
-        plugins=[plugin],
-    ):
-        label = "with" if add_temporal_runs else "without"
-        print(f"Worker started ({label} Temporal runs in traces), ctrl+c to exit")
-        await interrupt_event.wait()
-        print("Shutting down")
+    )
+
+    label = "with" if add_temporal_runs else "without"
+    print(f"Worker started ({label} Temporal runs in traces), ctrl+c to exit")
+    await worker.run()
 
 
 if __name__ == "__main__":
-    loop = asyncio.new_event_loop()
-    try:
-        loop.run_until_complete(main())
-    except KeyboardInterrupt:
-        interrupt_event.set()
-        loop.run_until_complete(loop.shutdown_asyncgens())
+    asyncio.run(main())