Only call one of the set_language operations

Author: dandavison

nexus_sync_operations/caller/workflows.py

@@ -4,7 +4,6 @@
 from message_passing.introduction.workflows import (
     GetLanguagesInput,
     SetLanguageInput,
-    SetLanguageUsingActivityInput,
 )
 
 with workflow.unsafe.imports_passed_through():
@@ -30,18 +29,8 @@ async def run(self) -> None:
 
         # Set language
         previous_language = await nexus_client.execute_operation(
-            GreetingService.set_language, SetLanguageInput(language=Language.CHINESE)
-        )
-        assert (
-            await nexus_client.execute_operation(GreetingService.get_language, None)
-            == Language.CHINESE
-        )
-        print(f"language changed: {previous_language.name} -> {Language.CHINESE.name}")
-
-        # Set language using remote service
-        previous_language = await nexus_client.execute_operation(
-            GreetingService.set_language_using_activity,
-            SetLanguageUsingActivityInput(language=Language.ARABIC),
+            GreetingService.set_language,
+            SetLanguageInput(language=Language.ARABIC),
         )
         assert (
             await nexus_client.execute_operation(GreetingService.get_language, None)

nexus_sync_operations/handler/service_handler.py

@@ -15,7 +15,6 @@
     GetLanguagesInput,
     GreetingWorkflow,
     SetLanguageInput,
-    SetLanguageUsingActivityInput,
 )
 from nexus_sync_operations.service import GreetingService
 
@@ -61,18 +60,10 @@ async def get_language(
 
     @nexusrpc.handler.sync_operation
     async def set_language(
-        self, ctx: nexusrpc.handler.StartOperationContext, input: SetLanguageInput
-    ) -> Language:
-        return await self.greeting_workflow_handle.execute_update(
-            GreetingWorkflow.set_language, input.language
-        )
-
-    @nexusrpc.handler.sync_operation
-    async def set_language_using_activity(
         self,
         ctx: nexusrpc.handler.StartOperationContext,
-        input: SetLanguageUsingActivityInput,
+        input: SetLanguageInput,
     ) -> Language:
         return await self.greeting_workflow_handle.execute_update(
-            GreetingWorkflow.set_language_using_activity, input.language
+            GreetingWorkflow.set_language_using_activity, input
         )

nexus_sync_operations/service.py

@@ -4,7 +4,6 @@
 from message_passing.introduction.workflows import (
     GetLanguagesInput,
     SetLanguageInput,
-    SetLanguageUsingActivityInput,
 )
 
 
@@ -13,6 +12,3 @@ class GreetingService:
     get_languages: nexusrpc.Operation[GetLanguagesInput, list[Language]]
     get_language: nexusrpc.Operation[None, Language]
     set_language: nexusrpc.Operation[SetLanguageInput, Language]
-    set_language_using_activity: nexusrpc.Operation[
-        SetLanguageUsingActivityInput, Language
-    ]

tests/nexus_sync_operations/nexus_sync_operations_test.py

@@ -1,5 +1,4 @@
 import asyncio
-import sys
 
 import pytest
 from temporalio.client import Client
@@ -15,9 +14,6 @@ async def test_nexus_sync_operations(client: Client, env: WorkflowEnvironment):
     if env.supports_time_skipping:
         pytest.skip("Nexus tests don't work under the Java test server")
 
-    if sys.version_info[:2] < (3, 10):
-        pytest.skip("Sample is written for Python >= 3.10")
-
     create_response = await create_nexus_endpoint(
         name=nexus_sync_operations.caller.workflows.NEXUS_ENDPOINT,
         task_queue=nexus_sync_operations.handler.worker.TASK_QUEUE,
@@ -29,26 +25,12 @@ async def test_nexus_sync_operations(client: Client, env: WorkflowEnvironment):
                 client,
             )
         )
-        # Give worker time to start the long-running workflow
-        await asyncio.sleep(1)
-
-        # Execute the caller workflow which will test all the Nexus operations
         await nexus_sync_operations.caller.app.execute_caller_workflow(
             client,
         )
-
-        # Clean up the handler worker
         nexus_sync_operations.handler.worker.interrupt_event.set()
         await handler_worker_task
         nexus_sync_operations.handler.worker.interrupt_event.clear()
-
-        # The test passes if the caller workflow completes successfully
-        # The caller workflow verifies that:
-        # - get_languages returns supported languages
-        # - set_language updates the language and returns the previous one
-        # - get_language returns the current language
-        # - set_language_using_activity updates the language using an activity
-        # - approve sends the signal successfully
     finally:
         await delete_nexus_endpoint(
             id=create_response.endpoint.id,