A bit of extra cleanup

Author: Sushisource

worker_versioning/activities.py

@@ -14,10 +14,10 @@ class IncompatibleActivityInput:
 @activity.defn
 async def some_activity(called_by: str) -> str:
     """Basic activity for the workflow."""
-    return f"SomeActivity called by {called_by}"
+    return f"some_activity called by {called_by}"
 
 
 @activity.defn
 async def some_incompatible_activity(input_data: IncompatibleActivityInput) -> str:
     """Incompatible activity that takes different input."""
-    return f"SomeIncompatibleActivity called by {input_data.called_by} with {input_data.more_data}"
+    return f"some_incompatible_activity called by {input_data.called_by} with {input_data.more_data}"

worker_versioning/app.py

@@ -6,7 +6,9 @@
 
 from temporalio.client import Client
 
-from worker_versioning.constants import DEPLOYMENT_NAME, TASK_QUEUE
+# Constants
+TASK_QUEUE = "worker-versioning"
+DEPLOYMENT_NAME = "my-deployment"
 
 logging.basicConfig(level=logging.INFO)
 
@@ -97,7 +99,6 @@ async def wait_for_worker_and_make_current(client: Client, build_id: str) -> Non
         deployment_name=DEPLOYMENT_NAME, build_id=build_id
     )
 
-    # Wait for the worker to appear
     while True:
         try:
             describe_request = wsv1.DescribeWorkerDeploymentRequest(
@@ -108,7 +109,6 @@ async def wait_for_worker_and_make_current(client: Client, build_id: str) -> Non
                 describe_request
             )
 
-            # Check if our version is present in the version summaries
             for version_summary in response.worker_deployment_info.version_summaries:
                 if (
                     version_summary.deployment_version.deployment_name

worker_versioning/constants.py

@@ -8,7 +8,7 @@
 from temporalio.worker import Worker, WorkerDeploymentConfig
 
 from worker_versioning.activities import some_activity, some_incompatible_activity
-from worker_versioning.constants import DEPLOYMENT_NAME, TASK_QUEUE
+from worker_versioning.app import DEPLOYMENT_NAME, TASK_QUEUE
 from worker_versioning.workflows import AutoUpgradingWorkflowV1, PinnedWorkflowV1
 
 logging.basicConfig(level=logging.INFO)

worker_versioning/workerv1.py

@@ -8,7 +8,7 @@
 from temporalio.worker import Worker, WorkerDeploymentConfig
 
 from worker_versioning.activities import some_activity, some_incompatible_activity
-from worker_versioning.constants import DEPLOYMENT_NAME, TASK_QUEUE
+from worker_versioning.app import DEPLOYMENT_NAME, TASK_QUEUE
 from worker_versioning.workflows import AutoUpgradingWorkflowV1b, PinnedWorkflowV1
 
 logging.basicConfig(level=logging.INFO)

worker_versioning/workerv1_1.py

@@ -8,7 +8,7 @@
 from temporalio.worker import Worker, WorkerDeploymentConfig
 
 from worker_versioning.activities import some_activity, some_incompatible_activity
-from worker_versioning.constants import DEPLOYMENT_NAME, TASK_QUEUE
+from worker_versioning.app import DEPLOYMENT_NAME, TASK_QUEUE
 from worker_versioning.workflows import AutoUpgradingWorkflowV1b, PinnedWorkflowV2
 
 logging.basicConfig(level=logging.INFO)