Skip to content

Commit c3af22a

Browse files
committed
fix data & tags
1 parent ab8c7bf commit c3af22a

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

taskbadger/sdk.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,10 @@ def create(
260260
monitor_id: str = None,
261261
tags: dict[str, str] = None,
262262
) -> "Task":
263-
"""Create a new task"""
263+
"""Create a new task
264+
265+
See [taskbadger.create_task][] for more information.
266+
"""
264267
return create_task(
265268
name,
266269
status,
@@ -342,6 +345,8 @@ def update(
342345
"""Generic update method used to update any of the task fields.
343346
344347
This can also be used to add actions.
348+
349+
See [taskbadger.update_task][] for more information.
345350
"""
346351
if data and data_merge_strategy:
347352
if hasattr(data_merge_strategy, "merge"):
@@ -379,8 +384,8 @@ def ping(self):
379384
self.update()
380385

381386
@property
382-
def data(self):
383-
return self._task.data.additional_properties
387+
def tags(self):
388+
return self._task.tags.to_dict()
384389

385390
def __getattr__(self, item):
386391
return getattr(self._task, item)

tests/test_sdk_primatives.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ def _json_task_response(**kwargs):
129129
"updated": "2022-09-22T06:53:40.683555Z",
130130
"url": None,
131131
"public_url": None,
132+
"tags": {"tag": "value"},
132133
}
133134
response.update(kwargs)
134135
return response
@@ -145,3 +146,4 @@ def _verify_task(task, **kwargs):
145146
assert task.value_max == expected["value_max"]
146147
assert task.value_percent == expected["value_percent"]
147148
assert task.data == expected["data"]
149+
assert task.tags == expected["tags"]

0 commit comments

Comments
 (0)