Skip to content

Commit a4b96c1

Browse files
committed
return task from safe methods
1 parent 34c65b9 commit a4b96c1

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

taskbadger/safe_sdk.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
log = logging.getLogger("taskbadger")
1515

1616

17-
def create_task_safe(name: str, **kwargs: P.kwargs) -> Optional[str]:
17+
def create_task_safe(name: str, **kwargs: P.kwargs) -> Optional[Task]:
1818
"""Safely create a task. Any errors are handled and logged.
1919
2020
Arguments:
@@ -28,14 +28,12 @@ def create_task_safe(name: str, **kwargs: P.kwargs) -> Optional[str]:
2828
return None
2929

3030
try:
31-
task = create_task(name, **kwargs)
31+
return create_task(name, **kwargs)
3232
except Exception:
3333
log.exception("Error creating task '%s'", name)
34-
else:
35-
return task.id
3634

3735

38-
def update_task_safe(task_id: str, **kwargs: P.kwargs) -> None:
36+
def update_task_safe(task_id: str, **kwargs: P.kwargs) -> Optional[Task]:
3937
"""Safely update a task. Any errors are handled and logged.
4038
4139
Arguments:
@@ -46,6 +44,6 @@ def update_task_safe(task_id: str, **kwargs: P.kwargs) -> None:
4644
return
4745

4846
try:
49-
update_task(task_id, **kwargs)
47+
return update_task(task_id, **kwargs)
5048
except Exception:
5149
log.exception("Error updating task '%s'", task_id)

0 commit comments

Comments
 (0)