improve error handling

Author: snopoke

taskbadger/errors.py

@@ -0,0 +1,18 @@
+class TaskbadgerException(Exception):
+    pass
+
+
+class Unauthorized(TaskbadgerException):
+    pass
+
+
+class UnexpectedStatus(TaskbadgerException):
+    def __init__(self, status_code: int, content: bytes):
+        self.status_code = status_code
+        self.content = content
+
+        super().__init__(f"Unexpected status code: {status_code}")
+
+
+class ServerError(UnexpectedStatus):
+    pass

taskbadger/sdk.py

@@ -4,9 +4,10 @@
 
 from _contextvars import ContextVar
 
-from taskbadger import Action
+from taskbadger.errors import ServerError, Unauthorized, UnexpectedStatus
 from taskbadger.exceptions import ConfigurationError
-from taskbadger.internal import AuthenticatedClient, errors
+from taskbadger.integrations import Action
+from taskbadger.internal import AuthenticatedClient
 from taskbadger.internal.api.task_endpoints import task_create, task_get, task_partial_update
 from taskbadger.internal.models import (
     PatchedTaskRequest,
@@ -174,9 +175,12 @@ def _get_settings():
 def _check_response(response):
     if 200 <= response.status_code < 300:
         return response
-
+    elif response.status_code == 401:
+        raise Unauthorized("Authentication failed")
+    elif response.status_code == 500:
+        raise ServerError(response.status_code, response.content)
     else:
-        raise errors.UnexpectedStatus(response.status_code, response.content)
+        raise UnexpectedStatus(response.status_code, response.content)
 
 
 @dataclasses.dataclass

tests/test_sdk_primatives.py

@@ -3,6 +3,7 @@
 import pytest
 
 from taskbadger import Action, EmailIntegration, StatusEnum, update_task
+from taskbadger.errors import ServerError, Unauthorized, UnexpectedStatus
 from taskbadger.sdk import create_task, get_task, init
 
 
@@ -37,6 +38,36 @@ def test_create_task(httpx_mock):
     _verify_task(task)
 
 
+def test_create_task_error_unauthed(httpx_mock):
+    httpx_mock.add_response(
+        url="https://taskbadger.net/api/org/project/tasks/",
+        method="POST",
+        status_code=401,
+    )
+    with pytest.raises(Unauthorized):
+        create_task("name")
+
+
+def test_create_task_error_server_error(httpx_mock):
+    httpx_mock.add_response(
+        url="https://taskbadger.net/api/org/project/tasks/",
+        method="POST",
+        status_code=500,
+    )
+    with pytest.raises(ServerError):
+        create_task("name")
+
+
+def test_create_task_error_unknown(httpx_mock):
+    httpx_mock.add_response(
+        url="https://taskbadger.net/api/org/project/tasks/",
+        method="POST",
+        status_code=412,
+    )
+    with pytest.raises(UnexpectedStatus):
+        create_task("name")
+
+
 def test_update_task(httpx_mock):
     expected_body = {
         "name": "new name",