npm install fails with TypeError: cannot use a string pattern on a bytes-like object

[pexarkh]

> npm install

> node-zopfli-es@1.0.0 install /Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es
> node-gyp rebuild

make: Entering directory '/Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es/build'
  CC(target) Release/obj.target/nothing/../node-addon-api/src/nothing.o
  LIBTOOL-STATIC Release/nothing.a
Traceback (most recent call last):
  File "./gyp-mac-tool", line 611, in <module>
    sys.exit(main(sys.argv[1:]))
  File "./gyp-mac-tool", line 28, in main
    exit_code = executor.Dispatch(args)
  File "./gyp-mac-tool", line 43, in Dispatch
    return getattr(self, method)(*args[1:])
  File "./gyp-mac-tool", line 246, in ExecFilterLibtool
    if not libtool_re.match(line) and not libtool_re5.match(line):
TypeError: cannot use a string pattern on a bytes-like object
make: *** [../node-addon-api/src/nothing.target.mk:156: Release/nothing.a] Error 1
make: Leaving directory '/Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/tandemseven/.nvm/versions/node/v8.11.3/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at emitTwo (events.js:126:13)
gyp ERR! stack     at ChildProcess.emit (events.js:214:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System Darwin 17.7.0
gyp ERR! command "/Users/tandemseven/.nvm/versions/node/v8.11.3/bin/node" "/Users/tandemseven/.nvm/versions/node/v8.11.3/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es
gyp ERR! node -v v8.11.3
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! node-zopfli-es@1.0.0 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the node-zopfli-es@1.0.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

[jonathantneal]

Thanks for reporting this, @pavelxt7. While I prefer to keep things simple, I added shrink-ray-current to see just how fast we could make the thing.

Let’s see if I can’t get it working anyway. Would you mind testing on different versions of NodeJS? Such as Node v10 or Node v11?

shrink-ray-current claims to work in Node v8 (see https://github.com/Alorel/shrink-ray/blob/master/package.json#L56) but it was only bumped in package.json to maintain node-zopfli-es compatibility, which is where your problem is initially reported.

If we can’t figure it out, I’ll gladly roll back to version 0.3.0 which didn’t include it.

[pexarkh]

same diff :) on 10.14.1
am going to try 11.4 now

> npm i

> node-zopfli-es@1.0.0 install /Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es
> node-gyp rebuild

make: Entering directory '/Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es/build'
  CC(target) Release/obj.target/nothing/../node-addon-api/src/nothing.o
  LIBTOOL-STATIC Release/nothing.a
Traceback (most recent call last):
  File "./gyp-mac-tool", line 611, in <module>
    sys.exit(main(sys.argv[1:]))
  File "./gyp-mac-tool", line 28, in main
    exit_code = executor.Dispatch(args)
  File "./gyp-mac-tool", line 43, in Dispatch
    return getattr(self, method)(*args[1:])
  File "./gyp-mac-tool", line 246, in ExecFilterLibtool
    if not libtool_re.match(line) and not libtool_re5.match(line):
TypeError: cannot use a string pattern on a bytes-like object
make: *** [../node-addon-api/src/nothing.target.mk:154: Release/nothing.a] Error 1
make: Leaving directory '/Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/tandemseven/.nvm/versions/node/v10.14.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Darwin 17.7.0
gyp ERR! command "/Users/tandemseven/.nvm/versions/node/v10.14.1/bin/node" "/Users/tandemseven/.nvm/versions/node/v10.14.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es
gyp ERR! node -v v10.14.1
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! node-zopfli-es@1.0.0 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the node-zopfli-es@1.0.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

[pexarkh]

no dice. fails on 11.4.0 as well

> npm i

> node-zopfli-es@1.0.0 install /Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es
> node-gyp rebuild

make: Entering directory '/Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es/build'
  CC(target) Release/obj.target/nothing/../node-addon-api/src/nothing.o
  LIBTOOL-STATIC Release/nothing.a
Traceback (most recent call last):
  File "./gyp-mac-tool", line 611, in <module>
    sys.exit(main(sys.argv[1:]))
  File "./gyp-mac-tool", line 28, in main
    exit_code = executor.Dispatch(args)
  File "./gyp-mac-tool", line 43, in Dispatch
    return getattr(self, method)(*args[1:])
  File "./gyp-mac-tool", line 246, in ExecFilterLibtool
    if not libtool_re.match(line) and not libtool_re5.match(line):
TypeError: cannot use a string pattern on a bytes-like object
make: *** [../node-addon-api/src/nothing.target.mk:154: Release/nothing.a] Error 1
make: Leaving directory '/Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/tandemseven/.nvm/versions/node/v11.4.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:189:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
gyp ERR! System Darwin 17.7.0
gyp ERR! command "/Users/tandemseven/.nvm/versions/node/v11.4.0/bin/node" "/Users/tandemseven/.nvm/versions/node/v11.4.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/tandemseven/development/t7/github/tandemseven--dra-web-frameworkless_git/node_modules/node-zopfli-es
gyp ERR! node -v v11.4.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! node-zopfli-es@1.0.0 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the node-zopfli-es@1.0.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.