Skip to content

Commit 26da412

Browse files
committed
update: refine extra GN arguments for V8 build configuration
1 parent 0b00dd9 commit 26da412

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ jobs:
2525
rust_target: x86_64-unknown-linux-gnu
2626
container: quay.io/pypa/manylinux_2_28_x86_64:latest
2727
v8_from_source: "1"
28-
extra_gn_args: v8_enable_temporal_support=false v8_monolithic_for_shared_library=true
28+
extra_gn_args: v8_enable_temporal_support=false v8_monolithic=true v8_monolithic_for_shared_library=true v8_use_external_startup_data=false
2929
docker_options: >-
3030
-e V8_FROM_SOURCE=1
31-
-e "EXTRA_GN_ARGS=v8_enable_temporal_support=false v8_monolithic_for_shared_library=true"
31+
-e "EXTRA_GN_ARGS=v8_enable_temporal_support=false v8_monolithic=true v8_monolithic_for_shared_library=true v8_use_external_startup_data=false"
3232
- runner: ubuntu-24.04-arm
3333
target: aarch64
3434
rust_target: aarch64-unknown-linux-gnu
@@ -43,7 +43,8 @@ jobs:
4343
env:
4444
# rusty_v8's prebuilt Linux archive uses a TLS model that cannot be
4545
# linked into a Python extension module on x86_64. Source builds set
46-
# v8_monolithic_for_shared_library so V8 uses shared-library-safe TLS.
46+
# v8_monolithic + v8_monolithic_for_shared_library so V8 uses
47+
# shared-library-safe TLS.
4748
# aarch64 uses the published rusty_v8 archive.
4849
V8_FROM_SOURCE: ${{ matrix.v8_from_source }}
4950
# The crates.io v8 archive does not include Chromium's

0 commit comments

Comments
 (0)