In MsdialConsoleAppCore/Parser/ConfigParser.cs, the console parameter parser appears to include commented-out handling for QC at least filter.
For LCMS this currently appears as:
//case "qc at least filter": if (value.ToUpper() == "TRUE" || value.ToUpper() == "FALSE") param.QcAtLeastFilter = bool.Parse(value); return;
There appears to be a similar commented line in the GCMS parser.
Since QcAtLeastFilter is already present on the parameter object, it was not clear whether this setting was intentionally left unavailable in console parameter files or simply not enabled.
Was this parser case commented out intentionally?
If not, would a small PR enabling this parser key be acceptable? The change would simply enable the existing parser case for both LCMS and GCMS, using the same boolean parsing style as neighboring filter settings.
case "qc at least filter": if (value.ToUpper() == "TRUE" || value.ToUpper() == "FALSE") param.QcAtLeastFilter = bool.Parse(value); return;
Thanks!
In
MsdialConsoleAppCore/Parser/ConfigParser.cs, the console parameter parser appears to include commented-out handling forQC at least filter.For LCMS this currently appears as:
//case "qc at least filter": if (value.ToUpper() == "TRUE" || value.ToUpper() == "FALSE") param.QcAtLeastFilter = bool.Parse(value); return;There appears to be a similar commented line in the GCMS parser.
Since
QcAtLeastFilteris already present on the parameter object, it was not clear whether this setting was intentionally left unavailable in console parameter files or simply not enabled.Was this parser case commented out intentionally?
If not, would a small PR enabling this parser key be acceptable? The change would simply enable the existing parser case for both LCMS and GCMS, using the same boolean parsing style as neighboring filter settings.
Thanks!