guid: kill indirection, use == operator for Equal()

This just... works. And is slightly faster than unsafe conversion, too.

Author: Noam Preil

sttp/guid/Guid.go

@@ -27,7 +27,6 @@ import (
 	"encoding/binary"
 	"errors"
 	"strconv"
-	"unsafe"
 
 	"github.com/google/uuid"
 )
@@ -45,25 +44,17 @@ func New() Guid {
 
 // IsZero determines if the Guid value is its zero value, i.e., empty.
 func (g Guid) IsZero() bool {
-	return Equal(g, Empty)
+	return g == Empty
 }
 
 // Equal returns true if this Guid and other Guid values are equal.
 func (g Guid) Equal(other Guid) bool {
-	a1 := (*uint64)(unsafe.Pointer(&g[0]))
-	a2 := (*uint64)(unsafe.Pointer(&g[8]))
-	b1 := (*uint64)(unsafe.Pointer(&other[0]))
-	b2 := (*uint64)(unsafe.Pointer(&other[8]))
-	return *a1 == *b1 && *a2 == *b2
+	return g == other
 }
 
 // Equal returns true if the a and b Guid values are equal.
 func Equal(a, b Guid) bool {
-	a1 := (*uint64)(unsafe.Pointer(&a[0]))
-	a2 := (*uint64)(unsafe.Pointer(&a[8]))
-	b1 := (*uint64)(unsafe.Pointer(&b[0]))
-	b2 := (*uint64)(unsafe.Pointer(&b[8]))
-	return *a1 == *b1 && *a2 == *b2
+	return a == b
 }
 
 // Compare returns an integer comparing this Guid (g) to other Guid. The result will be 0 if g==other, -1 if this g < other, and +1 if g > other.

sttp/guid/Guid_test.go

@@ -310,6 +310,53 @@ func testGuidToFromBytes(g Guid, gs string, swapEndianness bool, t *testing.T) {
 	}
 }
 
+func (g Guid) EqualIndirectBaseline(other Guid) bool {
+	return EqualBaseline(g, other)
+}
+
+func (g Guid) EqualIndirect(other Guid) bool {
+	return Equal(g, other)
+}
+
+func EqualBaseline(a, b Guid) bool {
+	for k := range 16 {
+		if a[k] != b[k] {
+			return false
+			break
+		}
+	}
+	return true
+
+}
+
+func BenchmarkEqualityIndirect(b *testing.B) {
+	list := []string{gs1, gs2, gs3, gs4, gs5, gs6, gsz}
+	glist := [7]Guid{}
+	for i := range list {
+		glist[i], _ = Parse(list[i])
+	}
+	b.ResetTimer()
+	for range b.N {
+		a, b := glist[0], glist[1]
+		equal := a.EqualIndirect(b)
+		_ = equal
+	}
+}
+
+func BenchmarkEqualityIndirectBaseline(b *testing.B) {
+	list := []string{gs1, gs2, gs3, gs4, gs5, gs6, gsz}
+	glist := [7]Guid{}
+	for i := range list {
+		glist[i], _ = Parse(list[i])
+	}
+	b.ResetTimer()
+	for range b.N {
+		a, b := glist[0], glist[1]
+		equal := a.EqualIndirectBaseline(b)
+		_ = equal
+	}
+}
+
 func BenchmarkEqualityBaseline(b *testing.B) {
 	list := []string{gs1, gs2, gs3, gs4, gs5, gs6, gsz}
 	glist := [7]Guid{}