Adressed comments from review

Author: aponcedeleonch

src/codegate/muxing/adapter.py

@@ -3,6 +3,7 @@
 import uuid
 from abc import ABC, abstractmethod
 from typing import Callable, Dict, Union
+from urllib.parse import urljoin
 
 import structlog
 from fastapi.responses import JSONResponse, StreamingResponse
@@ -31,13 +32,12 @@ class BodyAdapter:
 
     def _get_provider_formatted_url(self, model_route: rulematcher.ModelRoute) -> str:
         """Get the provider formatted URL to use in base_url. Note this value comes from DB"""
-        base_endpoint = model_route.endpoint.endpoint.rstrip("/")
         if model_route.endpoint.provider_type in [
             db_models.ProviderType.openai,
             db_models.ProviderType.openrouter,
         ]:
-            return f"{base_endpoint}/v1"
-        return base_endpoint
+            return urljoin(model_route.endpoint.endpoint, "/v1")
+        return model_route.endpoint.endpoint
 
     def set_destination_info(self, model_route: rulematcher.ModelRoute, data: dict) -> dict:
         """Set the destination provider info."""

src/codegate/providers/ollama/adapter.py

@@ -47,13 +47,18 @@ def __init__(self, ollama_response: AsyncIterator[ChatResponse]):
         self._aiter = ollama_response.__aiter__()
 
     @classmethod
-    def _transform_to_int_secs(cls, chunk_created_at) -> int:
-        # Convert the datetime object to a timestamp in seconds
+    def _transform_to_int_secs(cls, chunk_created_at: str) -> int:
+        """
+        Convert the datetime to a timestamp in seconds.
+        """
         datetime_obj = datetime.fromisoformat(chunk_created_at)
         return int(datetime_obj.timestamp())
 
     @classmethod
     def _get_finish_reason_assistant(cls, is_chunk_done: bool) -> Tuple[str, Optional[str]]:
+        """
+        Get the role and finish reason for the assistant based on the chunk done status.
+        """
         finish_reason = None
         role = "assistant"
         if is_chunk_done:
@@ -63,14 +68,20 @@ def _get_finish_reason_assistant(cls, is_chunk_done: bool) -> Tuple[str, Optiona
 
     @classmethod
     def _get_chat_id_from_timestamp(cls, timestamp_seconds: int) -> str:
+        """
+        Getting a string representation of the timestamp in seconds used as the chat id.
+
+        This needs to be done so that all chunks of a chat have the same id.
+        """
         timestamp_str = str(timestamp_seconds)
         return timestamp_str[:9]
 
     @classmethod
     def normalize_chat_chunk(cls, chunk: ChatResponse) -> ModelResponse:
-        # Convert the datetime object to a timestamp in seconds
+        """
+        Transform an ollama chat chunk to an OpenAI one
+        """
         timestamp_seconds = cls._transform_to_int_secs(chunk.created_at)
-        # Get role and finish reason
         role, finish_reason = cls._get_finish_reason_assistant(chunk.done)
         chat_id = cls._get_chat_id_from_timestamp(timestamp_seconds)
 
@@ -95,9 +106,7 @@ def normalize_fim_chunk(cls, chunk: GenerateResponse) -> Dict:
         """
         Transform an ollama generation chunk to an OpenAI one
         """
-        # Convert the datetime object to a timestamp in seconds
         timestamp_seconds = cls._transform_to_int_secs(chunk.created_at)
-        # Get role and finish reason
         _, finish_reason = cls._get_finish_reason_assistant(chunk.done)
         chat_id = cls._get_chat_id_from_timestamp(timestamp_seconds)