rework fix pmd systemprintln, guardlogstatement

Author: Benjosh95

examples/authentication/src/main/java/cloud/stackit/sdk/authentication/examples/AuthenticationExample.java

@@ -8,17 +8,14 @@
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.util.Scanner;
-import java.util.logging.Level;
-import java.util.logging.Logger;
 
 final class AuthenticationExample {
-	private static final Logger LOGGER = Logger.getLogger(AuthenticationExample.class.getName());
 
 	private static final String SERVICE_ACCOUNT_KEY_PATH = "/path/to/sa_key.json";
 	private static final String PRIVATE_KEY_PATH = "/path/to/private_key.pem";
 	private static final String SERVICE_ACCOUNT_MAIL = "name-1234@sa.stackit.cloud";
 
-	@SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.NPathComplexity"})
+	@SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.NPathComplexity", "PMD.SystemPrintln"})
 	public static void main(String[] args) {
 		/* OPTION 1: setting the paths to service account key (and private key) as configuration */
 		try {
@@ -33,9 +30,7 @@ public static void main(String[] args) {
 			ListOrganizationsResponse response =
 					api.listOrganizations(null, SERVICE_ACCOUNT_MAIL, null, null, null);
 
-			if (LOGGER.isLoggable(Level.INFO)) {
-				LOGGER.info(response.toString());
-			}
+			System.out.println(response.toString());
 		} catch (ApiException | IOException e) {
 			throw new IllegalStateException(e);
 		}
@@ -57,9 +52,7 @@ public static void main(String[] args) {
 				serviceAccountKeyContent.append(myReader.nextLine());
 			}
 		} catch (FileNotFoundException e) {
-			if (LOGGER.isLoggable(Level.SEVERE)) {	
-				LOGGER.severe("File not found: " + serviceAccountKeyPath);
-			}
+			System.err.println("File not found: " + serviceAccountKeyPath);
 			return;
 		}
 
@@ -72,9 +65,7 @@ public static void main(String[] args) {
 				privateKeyContent.append(myReader.nextLine());
 			}
 		} catch (FileNotFoundException e) {
-			if (LOGGER.isLoggable(Level.SEVERE)) {
-				LOGGER.severe("File not found: " + privateKeyPath);
-			}
+			System.err.println("File not found: " + privateKeyPath);
 			return;
 		}
 
@@ -93,9 +84,7 @@ public static void main(String[] args) {
 			ListOrganizationsResponse response =
 					api.listOrganizations(null, SERVICE_ACCOUNT_MAIL, null, null, null);
 
-			if (LOGGER.isLoggable(Level.INFO)) {
-				LOGGER.info(response.toString());
-			}
+			System.out.println(response.toString());
 		} catch (ApiException | IOException e) {
 			throw new IllegalStateException(e);
 		}
@@ -132,9 +121,7 @@ public static void main(String[] args) {
 			ListOrganizationsResponse response =
 					api.listOrganizations(null, SERVICE_ACCOUNT_MAIL, null, null, null);
 
-			if (LOGGER.isLoggable(Level.INFO)) {
-				LOGGER.info(response.toString());
-			}
+			System.out.println(response.toString());
 		} catch (ApiException | IOException e) {
 			throw new IllegalStateException(e);
 		}

examples/custom-http-client/src/main/java/cloud/stackit/sdk/customhttpclient/examples/CustomHttpClientExample.java

@@ -7,8 +7,6 @@
 import cloud.stackit.sdk.iaas.model.*;
 import java.io.IOException;
 import java.util.UUID;
-import java.util.logging.Level;
-import java.util.logging.Logger;
 import okhttp3.OkHttpClient;
 
 /*
@@ -24,8 +22,8 @@
  *
  * */
 public class CustomHttpClientExample {
-	private static final Logger LOGGER = Logger.getLogger(CustomHttpClientExample.class.getName());
 
+	@SuppressWarnings("PMD.SystemPrintln")
 	public static void main(String[] args) throws IOException {
 		// Credentials are read from the credentialsFile in `~/.stackit/credentials.json` or the env
 		// STACKIT_SERVICE_ACCOUNT_KEY_PATH / STACKIT_SERVICE_ACCOUNT_KEY
@@ -41,19 +39,17 @@ public static void main(String[] args) throws IOException {
 		// the id of your STACKIT project, read from env var for this example
 		String projectIdString = System.getenv("STACKIT_PROJECT_ID");
 		if (projectIdString == null || projectIdString.isEmpty()) {
-			LOGGER.severe("Environment variable 'STACKIT_PROJECT_ID' not found.");
+			System.err.println("Environment variable 'STACKIT_PROJECT_ID' not found.");
 			return;
 		}
 		UUID projectId = UUID.fromString(projectIdString);
 
 		try {
 			/* list all servers */
 			ServerListResponse servers = iaasApi.listServers(projectId, false, null);
-			if (LOGGER.isLoggable(Level.INFO)) {
-				LOGGER.info("\nAvailable servers: ");
-				for (Server server : servers.getItems()) {
-					LOGGER.info("* " + server.getId() + " | " + server.getName());
-				}
+			System.out.println("\nAvailable servers: ");
+			for (Server server : servers.getItems()) {
+				System.out.println("* " + server.getId() + " | " + server.getName());
 			}
 		} catch (ApiException e) {
 			throw new IllegalStateException(e);