breaking(loadbalancer) refactor DeleteLoadBalancerWaitHandler signature

Author: cgoetz-inovex

CHANGELOG.md

@@ -176,6 +176,7 @@
     - **Dependencies:** Bump STACKIT SDK core module to `v0.26.0`
   - [v1.13.0](services/loadbalancer/CHANGELOG.md#v1130)
     - **Improvement:** Use new WaiterHelper for LoadBalancer waiters
+    - **Breaking Change:** `v2api/wait/DeleteLoadBalancerWaitHandler` now returns a `LoadBalancer` instead of `struct{}`
 - `logme`: 
   - [v0.27.3](services/logme/CHANGELOG.md#v0273) 
     - **Dependencies:** Bump STACKIT SDK core module from `v0.24.0` to `v0.24.1`

services/loadbalancer/CHANGELOG.md

@@ -1,5 +1,6 @@
 ## v1.13.0
 - **Improvement:** Use new WaiterHelper for LoadBalancer waiters
+- **Breaking Change:** `v2api/wait/DeleteLoadBalancerWaitHandler` now returns a `LoadBalancer` instead of `struct{}`
 
 ## v1.12.2
 - **Dependencies:** Bump STACKIT SDK core module to `v0.26.0`

services/loadbalancer/v2api/wait/wait.go

@@ -46,15 +46,16 @@ func CreateLoadBalancerWaitHandler(ctx context.Context, a loadbalancer.DefaultAP
 }
 
 // DeleteLoadBalancerWaitHandler will wait for load balancer deletion
-func DeleteLoadBalancerWaitHandler(ctx context.Context, a loadbalancer.DefaultAPI, projectId, region, instanceId string) *wait.AsyncActionHandler[struct{}] {
-	waitConfig := wait.WaiterHelper[struct{}, string]{
-		FetchInstance: func() (*struct{}, error) {
-			_, err := a.GetLoadBalancer(ctx, projectId, region, instanceId).Execute()
-			return &struct{}{}, err
-		},
-		GetState: func(_ *struct{}) (string, error) {
-			return "", nil
+func DeleteLoadBalancerWaitHandler(ctx context.Context, a loadbalancer.DefaultAPI, projectId, region, instanceId string) *wait.AsyncActionHandler[loadbalancer.LoadBalancer] {
+	waitConfig := wait.WaiterHelper[loadbalancer.LoadBalancer, string]{
+		FetchInstance: a.GetLoadBalancer(ctx, projectId, region, instanceId).Execute,
+		GetState: func(l *loadbalancer.LoadBalancer) (string, error) {
+			if l == nil || l.Status == nil {
+				return "", errors.New("response or status is nil")
+			}
+			return *l.Status, nil
 		},
+		ErrorState: []string{LOADBALANCERSTATUS_ERROR},
 	}
 	handler := wait.New(waitConfig.Wait())
 	handler.SetTimeout(15 * time.Minute)