Skip to content

Commit 8540bdb

Browse files
committed
fix test api calls
1 parent 459fdac commit 8540bdb

3 files changed

Lines changed: 123 additions & 79 deletions

File tree

pkg/ccm/loadbalancer_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ var _ = Describe("LoadBalancer", func() {
205205
}, nil)
206206
// TODO: match payload
207207
mockClient.EXPECT().CreateCredentials(gomock.Any(), gomock.Any()).MinTimes(1).
208-
DoAndReturn(func(_ context.Context, _ string, payload loadbalancer.CreateCredentialsPayload) (*loadbalancer.CreateCredentialsResponse, error) {
208+
DoAndReturn(func(_ context.Context, payload loadbalancer.CreateCredentialsPayload) (*loadbalancer.CreateCredentialsResponse, error) {
209209
return &loadbalancer.CreateCredentialsResponse{
210210
Credential: &loadbalancer.CredentialsResponse{
211211
CredentialsRef: new("my-credential-ref"),
@@ -276,7 +276,7 @@ var _ = Describe("LoadBalancer", func() {
276276
gomock.Any(),
277277
loadBalancer.GetLoadBalancerName(context.Background(), clusterName, svc),
278278
versionMatcher("current-version"),
279-
).MinTimes(1).Return(myLb, nil)
279+
).MinTimes(1).Return(nil)
280280

281281
svc = svc.DeepCopy()
282282
svc.Spec.Ports = append(svc.Spec.Ports, corev1.ServicePort{
@@ -333,7 +333,7 @@ var _ = Describe("LoadBalancer", func() {
333333
gomock.Any(),
334334
loadBalancer.GetLoadBalancerName(context.Background(), clusterName, svc),
335335
versionMatcher("current-version"),
336-
).MinTimes(1).Return(myLb, nil)
336+
).MinTimes(1).Return(nil)
337337

338338
_, err = loadBalancer.EnsureLoadBalancer(context.Background(), clusterName, svc, []*corev1.Node{nodeA, nodeB})
339339
Expect(err).NotTo(HaveOccurred())
@@ -374,7 +374,7 @@ var _ = Describe("LoadBalancer", func() {
374374
versionMatcher("current-version"),
375375
hasNoObservabilityConfigured(),
376376
),
377-
).MinTimes(1).Return(myLb, nil),
377+
).MinTimes(1).Return(nil),
378378
mockClient.EXPECT().DeleteCredentials(gomock.Any(), gomock.Any()).MinTimes(1).Return(nil),
379379
)
380380

@@ -459,7 +459,7 @@ var _ = Describe("LoadBalancer", func() {
459459
gomock.InOrder(
460460
mockClient.EXPECT().UpdateLoadBalancer(gomock.Any(), name, gomock.All(
461461
hasNoObservabilityConfigured(), externalAddressSet("8.8.4.4"),
462-
)).MinTimes(1).Return(&loadbalancer.LoadBalancer{}, nil),
462+
)).MinTimes(1).Return(nil),
463463
mockClient.EXPECT().DeleteCredentials(gomock.Any(), sampleCredentialsRef).MinTimes(1).Return(nil),
464464
mockClient.EXPECT().ListCredentials(gomock.Any()).Return(&loadbalancer.ListCredentialsResponse{
465465
Credentials: []loadbalancer.CredentialsResponse{},
@@ -493,7 +493,7 @@ var _ = Describe("LoadBalancer", func() {
493493
gomock.InOrder(
494494
mockClient.EXPECT().UpdateLoadBalancer(gomock.Any(), name, gomock.All(
495495
hasNoObservabilityConfigured(), externalAddressNotSet(), ephemeralAddress(),
496-
)).MinTimes(1).Return(&loadbalancer.LoadBalancer{}, nil),
496+
)).MinTimes(1).Return(nil),
497497
mockClient.EXPECT().DeleteCredentials(gomock.Any(), sampleCredentialsRef).MinTimes(1).Return(nil),
498498
mockClient.EXPECT().ListCredentials(gomock.Any()).Return(&loadbalancer.ListCredentialsResponse{
499499
Credentials: []loadbalancer.CredentialsResponse{},

0 commit comments

Comments
 (0)