As it stands currently, this project offers a nice API, but is not quite a Framework that others can easily reuse and extend.
This stems from 2 noticeable limitations:
-
Both the Guards and MapMapper types are package-private, making them difficult to reuse in external implementations of the BindingsPropertiesProcessor interface for convenience.
-
The Binding and Bindings classes really should not be final as it makes them difficult to mock, or at least spy on in a true Unit Test.
Making these changes will make the project more Framework-like, being 1) reusable and 2) "open for extension, but closed for modification".
Thank you for the consideration.
As it stands currently, this project offers a nice API, but is not quite a Framework that others can easily reuse and extend.
This stems from 2 noticeable limitations:
Both the
GuardsandMapMappertypes are package-private, making them difficult to reuse in external implementations of theBindingsPropertiesProcessorinterface for convenience.The
BindingandBindingsclasses really should not be final as it makes them difficult to mock, or at least spy on in a true Unit Test.Making these changes will make the project more Framework-like, being 1) reusable and 2) "open for extension, but closed for modification".
Thank you for the consideration.